NVDA will no longer announce "pane" when minimizing Windows#6672
Closed
josephsl wants to merge 2 commits into
Closed
NVDA will no longer announce "pane" when minimizing Windows#6672josephsl wants to merge 2 commits into
josephsl wants to merge 2 commits into
Conversation
… spacing for class separations, ticket 474 comment now follows the rest of the source code. Part of a larger work on source code work: added a top-level docstring describing the purpose of the explorer.exe app module. Each class definition is separated by two spaces for style purposes.
…windows or moving to desktop. re nvaccess#6671 Somehow, when pressing Windows=M or Windows+D, NVDA says, 'pane'. It turns out there is a window with the window class name of 'WorkerW' that presents a focus event. Thus suppress this, which means NVDA will no longer announce 'pane' when minimizing Windows. This bug affects various versions of Windows (tested with Windows 7 and Windows 10).
Contributor
Author
|
Requesting review from @jcsteh please. Thanks. |
feerrenrut
reviewed
Dec 30, 2016
|
|
||
| class ImmersiveLauncher(UIA): | ||
| #When the win8 start screen openes, focus correctly goes to the first tile, but then incorrectly back to the root of the window. | ||
| #When the win8 start screen opens, focus correctly goes to the first tile, but then incorrectly back to the root of the window. |
Contributor
There was a problem hiding this comment.
Not a big deal, but other comments tend to have a space after the # symbol.
Contributor
Author
|
Hi, yep, minor thing. If you want, as part of a possible squash merge, you can add a space for readability purposes. Thanks for catching that.
From: Reef Turner [mailto:notifications@github.com]
Sent: Thursday, December 29, 2016 8:36 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] NVDA will no longer announce "pane" when minimizing Windows (#6672)
@feerrenrut commented on this pull request.
_____
In source/appModules/explorer.py <#6672 (review)> :
class ImmersiveLauncher(UIA):
- #When the win8 start screen openes, focus correctly goes to the first tile, but then incorrectly back to the root of the window.
+ #When the win8 start screen opens, focus correctly goes to the first tile, but then incorrectly back to the root of the window.
Not a big deal, but other comments tend to have a space after the # symbol.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#6672 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkCBJpAOr_itCivvgP4lk2yqVIj8Iks5rNIoegaJpZM4LVJ0e> .
|
Contributor
|
Out of interest I've had a quick look at this. The changes look good to me, perhaps you can comment on the testing performed? However since you requested @jcsteh to review, I'll leave this to him to approve. |
Contributor
Author
|
Hi Reef, if you want, you can go ahead and let it incubate. I asked Jamie because I was used to getting reviews from him in the past (I think he is in vacation for a few days). Thanks for taking a look at this.
From: Reef Turner [mailto:notifications@github.com]
Sent: Thursday, December 29, 2016 8:38 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] NVDA will no longer announce "pane" when minimizing Windows (#6672)
Out of interest I've had a quick look at this. The changes look good to me, perhaps you can comment on the testing performed? However since you requested @jcsteh <https://github.com/jcsteh> to review, I'll leave this to him to approve.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#6672 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkJgDvsXj7fGjm1Nj8Hm0qh2P8rqeks5rNIqNgaJpZM4LVJ0e> .
|
Contributor
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for issue #6671: in app modules/explorer.event_gainFocus, add a case where a window with the class name of "WorkerW" attempts to send a gain focus event, which should be suppressed.
Suggested what's new entry (under bug fixes): NVDA will no longer announce "pane" when minimizing windows.
Thanks.