Excel cell border announcement #3044#6492
Closed
nishimotz wants to merge 6 commits into
Closed
Conversation
…cell border is different from the adjacent cells. nvaccess#3044
michaelDCurran
requested changes
Jan 19, 2017
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
I get the following error when manually reporting formatting with NVDA+f when on an cell in Excel:
ERROR - scriptHandler.executeScript (10:49:44):
error executing script: <bound method GlobalCommands.script_reportFormatting of <globalCommands.GlobalCommands object at 0x05DA40F0>> with gesture u'NVDA+f'
Traceback (most recent call last):
File "scriptHandler.py", line 187, in executeScript
script(gesture)
File "globalCommands.py", line 1287, in script_reportFormatting
for field in info.getTextWithFields(formatConfig):
File "textInfos\offsets.py", line 392, in getTextWithFields
field,(boundStart,boundEnd)=self._getFormatFieldAndOffsets(self._startOffset,formatConfig,calculateOffsets=False)
File "NVDAObjects\window\excel.py", line 963, in _getFormatFieldAndOffsets
if formatConfig["reportBorderStyle"]:
KeyError: 'reportBorderStyle'
Other than that this looks good.
…cell border is different from the adjacent cells. NVDA+F should work on Excel as well. nvaccess#3044 PR nvaccess#6492
michaelDCurran
approved these changes
Jan 19, 2017
…cell border is different from the adjacent cells. NVDA+F should work on Excel as well. Now merged master and resolved confict regarding configSpec. nvaccess#3044 PR nvaccess#6492
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information about the cell border is given in an Excel sheet, if the cell border is different from the adjacent cells. #3044