Skip to content

No longer set the language before restarting#6415

Merged
feerrenrut merged 1 commit into
masterfrom
i4561_fixUiLangChange
Oct 27, 2016
Merged

No longer set the language before restarting#6415
feerrenrut merged 1 commit into
masterfrom
i4561_fixUiLangChange

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

See issue #4561
When a new language is selected (on the general settings dialog) and the ok
button is pushed, the language is not changed until until NVDA is restarted.

This fixes an issue where some parts of the UI are translated and some
are not.

Note there is now a change in behaviour, the dialog asking for a restart is no longer translated.
Good: If you know the existing language and accidentally change it, you are given a warning can understand, hit cancel, and set it back to the existing language.
Bad: If you dont know the existing language you are presented with a dialog you can not understand. However you have managed to get to this point in a language you dont know.

See issue #4561
When a new language is selected (on the general settings dialog) and the ok
button is pushed, the language is not changed until until NVDA is restarted.

This fixes an issue where some parts of the UI are translated and some
are not.
@feerrenrut

Copy link
Copy Markdown
Contributor Author

@michaelDCurran would you mind reviewing this?

@michaelDCurran

Copy link
Copy Markdown
Member

All looks fine to me.

feerrenrut added a commit that referenced this pull request Oct 4, 2016
See issue #4561

Merge branch 'i4561_fixUiLangChange' into next
@feerrenrut feerrenrut merged commit 91159a2 into master Oct 27, 2016
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 27, 2016
feerrenrut added a commit that referenced this pull request Oct 27, 2016
You can now assign an input gesture to toggle simple review mode using the Input Gestures dialog. (Issue: #6173)
@bhavyashah

Copy link
Copy Markdown

Hi Reef,
To reflect the new more desirable behaviour, I propose an extremely
and insubstantially minor option label change, for now this option
'requires restart to take effect' (at all) and not 'requires restart
to fully take effect'. This slight revision may only emphasize the
absolute necessity of a restart for any UI language changes to take
place, as opposed to the prior 'fullness' of the UI language change
that a restart provided.
Thanks.

On 10/27/16, Reef Turner notifications@github.com wrote:

Merged #6415.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#6415 (comment)

Best Regards
Bhavya Shah

Avid Enthusiast and User of the Free NVDA Screen Reader (www.nvaccess.org)

Contacting Me
E-mail Address: bhavya.shah125@gmail.com
Follow me on Twitter @BhavyaShah125 or www.twitter.com/BhavyaShah125
Mobile Number: +91 7506221750

@feerrenrut feerrenrut deleted the i4561_fixUiLangChange branch January 17, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants