The reload plugins command no longer causes problems for triggered configuration profiles, new documents in web browsers and screen review.#6390
Merged
Conversation
…nfiguration profiles, new documents in web browsers and screen review. When reloading app modules, transfer necessary state (the nvdaHelperRemote connection and config profile trigger) from the old AppModule instances to the newly loaded instances. Ensure the focus object, focus ancestors and navigator object know about their new AppModule.
Contributor
Author
|
@michaelDCurran, can you please review? This is a bit ugly, but I don't think there's a cleaner way to do it. Note that I didn't want to add an argument to |
Member
|
All looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reloading app modules, transfer necessary state (the nvdaHelperRemote connection and config profile trigger) from the old AppModule instances to the newly loaded instances. Ensure the focus object, focus ancestors and navigator object know about their new AppModule.
Fixes #2892. Fixes #5380.