I6312 fix mouse interaction symbol list#6328
Merged
Merged
Conversation
Updating the symbol list items as the "change symbol" fields are changed fixes an issue where the values for the items in the list were not updated when the mouse was used to select a new item in the list. When the already selected (and now changed) item was reselected, then the item in the list WAS updated. This issue seemed to be caused by the EVT_KILL_FOCUS and the EVT_LIST_ITEM_FOCUSED being received out of order. Disables "change symbol" fields when no item is selected (when dialog is first opened. Seeing the fields disabled helps to indicate that an item must be selected first. When this happens its clear that the fields relate to the selected item, as they can be seen to update. Fixes #6312
Contributor
Author
|
@jcsteh Could you please take a look at this when you have a chance? |
| @@ -1636,31 +1636,53 @@ def makeSettings(self, settingsSizer): | |||
| settingsSizer.Add(sizer) | |||
|
|
|||
| # Translators: The label for the edit field in symbol pronunciation dialog to change the pronunciation of a symbol. | |||
Contributor
There was a problem hiding this comment.
I realise you didn't write this translators comment, but while you're here, can you please change "edit field" to "group of controls"?
Contributor
|
I'm happy with this. Go ahead and incubate! |
feerrenrut
added a commit
that referenced
this pull request
Sep 5, 2016
feerrenrut
added a commit
that referenced
this pull request
Sep 19, 2016
The mouse can now be used to move focus between the symbol list and the edit fields in the symbol pronunciation dialog. (#6312)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling Skip() on the focus events fixes the "unable to type in the replacement field when using the mouse to focus it" issue.
Updating the symbol list items as the "change symbol" fields are
changed fixes an issue where the values for the items in the list were
not updated when the mouse was used to select a new item in the list.
When the already selected (and now changed) item was reselected, then
the item in the list WAS updated.
This issue seemed to be caused by the EVT_KILL_FOCUS and the
EVT_LIST_ITEM_FOCUSED being received out of order.
Disables "change symbol" fields when no item is selected (when dialog is
first opened. Seeing the fields disabled helps to indicate that an item
must be selected first. When this happens its clear that the fields
relate to the selected item, as they can be seen to update.
Fixes #6312