Language handler: Aragonese is no longer displayed as 'unknown language' in General Settings/language combo box. re #6259#6261
Merged
Conversation
…ge'. re nvaccess#6259 According to MSDN, LCID 0x1000 (4096) is treated as a custom locale by users. This affected how Aragonese entry is presented in General Settings/language combo box (in Windows 10, it shows up as 'unknown language'). Thus take care of this case. Also took this time to add needed copyright headers (based on git log archive).
jcsteh
requested changes
Sep 22, 2016
| if LCID!=0: | ||
| # #6259: LCID 0x1000 denotes custom locale in Windows 10, thus returns "unknown language" or an odd description (observed for Aragonese). | ||
| # See https://msdn.microsoft.com/en-us/library/system.globalization.cultureinfo.lcid(v=vs.110).aspx. | ||
| if LCID not in (0, 4096): |
Contributor
There was a problem hiding this comment.
Please change 4096 to 0x1000, as the intent is clearer this way. Thanks!
Reviewed by Jamie Teh (NV Access): use hex for clarity.
jcsteh
approved these changes
Sep 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to MSDN, LCID 0x1000 (4096) is treated as a custom locale by users. This affected how Aragonese entry is presented in General Settings/language combo box (in Windows 10, it shows up as 'unknown language'). Thus take care of this case.
Also took this time to add needed copyright headers (based on git log archive).
Suggested what's new entry:
Category: bug fixes
When viewing list of languages in general settings dialog, certain language entries (for example, Aragonese) are displayed correctly when NVDA is running on Windows 10. (#6259)
Fixes #6259.