Skip to content

Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech#6166

Closed
michaelDCurran wants to merge 5 commits into
masterfrom
i6159
Closed

Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech#6166
michaelDCurran wants to merge 5 commits into
masterfrom
i6159

Conversation

@michaelDCurran

Copy link
Copy Markdown
Member

Fixes #6159

michaelDCurran added a commit that referenced this pull request Jul 11, 2016
Comment thread source/synthDrivers/sapiMobile.py Outdated
@@ -0,0 +1,43 @@
# -*- coding: UTF-8 -*-
#synthDrivers/sapi5.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to reflect the correct module name. ;)

… change to sapi5, and re-implement sapi5 pause with ISPAudio.setState.
@LeonarddeR

Copy link
Copy Markdown
Collaborator

The mobile part of this pr is superseded by #7110. Not sure about the sapi part though.

@jcsteh

jcsteh commented May 11, 2017 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran

michaelDCurran commented May 12, 2017 via email

Copy link
Copy Markdown
Member Author

@jcsteh

jcsteh commented May 12, 2017 via email

Copy link
Copy Markdown
Contributor

@michaelDCurran

michaelDCurran commented May 12, 2017 via email

Copy link
Copy Markdown
Member Author

@LeonarddeR

Copy link
Copy Markdown
Collaborator

@michaelDCurran: Do you think this could fix #5779 as well?

@jcsteh

jcsteh commented Aug 7, 2017

Copy link
Copy Markdown
Contributor

Note that the lag/pause fix will probably help (and should be applied to) Microsoft Speech Platform as well. See #1961.

@josephsl

Copy link
Copy Markdown
Contributor

Hi,

Should we put this on the table for 2018? Thanks.

@derekriemer

Copy link
Copy Markdown
Collaborator

wait, isn't this in NVDA now?

@josephsl

josephsl commented Sep 29, 2017 via email

Copy link
Copy Markdown
Contributor

@Brian1Gaff

Brian1Gaff commented Sep 29, 2017 via email

Copy link
Copy Markdown

@derekriemer

Copy link
Copy Markdown
Collaborator

I.E. what is not in NVDA that is in this?

@josephsl

josephsl commented Sep 30, 2017 via email

Copy link
Copy Markdown
Contributor

@Brian1Gaff

Brian1Gaff commented Sep 30, 2017 via email

Copy link
Copy Markdown

@dineshkaushal

dineshkaushal commented Nov 6, 2017 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR

Copy link
Copy Markdown
Collaborator

@michaelDCurran: Is this pr still on your radar?

@michaelDCurran

Copy link
Copy Markdown
Member Author

We now support Onecore voices via their own driver. and the fix for SAPI5 lag at end of speech has now been handled in its own PR #8174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants