Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech#6166
Closed
michaelDCurran wants to merge 5 commits into
Closed
Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech#6166michaelDCurran wants to merge 5 commits into
michaelDCurran wants to merge 5 commits into
Conversation
…peech in sapi5. Fixes #6159
…for sapi5 / Speech Mobile
michaelDCurran
added a commit
that referenced
this pull request
Jul 11, 2016
| @@ -0,0 +1,43 @@ | |||
| # -*- coding: UTF-8 -*- | |||
| #synthDrivers/sapi5.py | |||
Collaborator
There was a problem hiding this comment.
This should be changed to reflect the correct module name. ;)
… change to sapi5, and re-implement sapi5 pause with ISPAudio.setState.
Collaborator
|
The mobile part of this pr is superseded by #7110. Not sure about the sapi part though. |
Contributor
|
@michaelDCurran, thoughts? Do we still want the SAPI5 fixes here? This
might still help Windows 8 users, but it might also break some other
synths; it's impossible to say for certain.
|
Member
Author
|
I think we should keep the lag/pause fix, at least for voices that
report as 'Microsoft'.
|
Contributor
|
Okay. Since this is your PR, will you take care of this at some point or do
you want it reassigned?
|
Member
Author
|
I can look at it.
|
Collaborator
|
@michaelDCurran: Do you think this could fix #5779 as well? |
Contributor
|
Note that the lag/pause fix will probably help (and should be applied to) Microsoft Speech Platform as well. See #1961. |
Contributor
|
Hi, Should we put this on the table for 2018? Thanks. |
Collaborator
|
wait, isn't this in NVDA now? |
Contributor
|
Hi, at least OneCore voices support is.
From: Derek Riemer [mailto:notifications@github.com]
Sent: Friday, September 29, 2017 2:51 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech (#6166)
wait, isn't this in NVDA now?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#6166 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkC1ETbdvDX2fSBsgvArl9cUZdRC1ks5snL2VgaJpZM4JJApg> .
|
|
Is this something new? Are these different to the normal sappi 5 voices we
already see in nvda?
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
Collaborator
|
I.E. what is not in NVDA that is in this? |
Contributor
|
Hi, I’m thinking more of reducing lag in SAPI5 (Mick knows more about this). Thanks.
From: Derek Riemer [mailto:notifications@github.com]
Sent: Friday, September 29, 2017 7:50 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Add support for MS SAPI Mobile voices, and remove the lag at end of sapi5 speech (#6166)
I.E. what is not in NVDA that is in this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#6166 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkBCZan8A2DHOtVK3N7B0qCr75XCJks5snaxggaJpZM4JJApg> .
|
|
Hmm, lag? I always thought any lag in this was due to the system reading
ahead for correct intonation in the reading.
Its not too bad even in older machines for me as a say all reading synth,
albeit that Microsoft insist on setting the abbreviations to us ones when in
other areas of English world they mean something else!
Brian
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Brian Gaff" <bglists@blueyonder.co.uk>; "Comment"
<comment@noreply.github.com>
Sent: Saturday, September 30, 2017 1:37 PM
Subject: Re: [nvaccess/nvda] Add support for MS SAPI Mobile voices, and
remove the lag at end of sapi5 speech (#6166)
Hi, I’m thinking more of reducing lag in SAPI5 (Mick knows more about this).
Thanks.
From: Derek Riemer [mailto:notifications@github.com]
Sent: Friday, September 29, 2017 7:50 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment
<comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Add support for MS SAPI Mobile voices, and
remove the lag at end of sapi5 speech (#6166)
I.E. what is not in NVDA that is in this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6166 (comment)> , or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AHgLkBCZan8A2DHOtVK3N7B0qCr75XCJks5snaxggaJpZM4JJApg>
.
…--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#6166 (comment)
|
Contributor
|
Can the lag issue be included in NVDA? I am trying out a synthesizer i.e. flite. This synthesizer does not stop the speech for a while. But when I try with this branch the speech stops immediately on pressing control.
When I checked, I found that it happens because this branch accesses the AudioStream from SAPI5 and stops the stream on pause and cancel.
|
Collaborator
|
@michaelDCurran: Is this pr still on your radar? |
Member
Author
|
We now support Onecore voices via their own driver. and the fix for SAPI5 lag at end of speech has now been handled in its own PR #8174 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6159