Skip to content

beta to master#20239

Merged
seanbudd merged 2 commits into
masterfrom
beta
May 29, 2026
Merged

beta to master#20239
seanbudd merged 2 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

actions-user and others added 2 commits May 28, 2026 03:00
…ory even if Discard button is then pressed (#20236)

Fixes #20235

Fix-up of #20050
Summary of the issue:

When pressing apply in Magnifier settings panel, the values were not kept in memory. Thus, if dialog was then discarded, the initial values memorized when the dialog was opened were restored instead of the ones after Aply has been pressed.
Description of user facing changes:

When Mag settings dialog is discarded, the values of parameters present in the dialog when Apply was pressed are now restored as expected.
Description of developer facing changes:

N/A
Description of development approach:

Updated the *initially variables when settings panel is saved, i.e. when Apply or OK are pressed.
For OK, this has no impact since the dialog is closed.
Copilot AI review requested due to automatic review settings May 29, 2026 01:44
@seanbudd seanbudd requested a review from a team as a code owner May 29, 2026 01:44
@seanbudd seanbudd requested a review from SaschaCowley May 29, 2026 01:44
@seanbudd seanbudd merged commit 637e97c into master May 29, 2026
22 of 23 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions github-actions Bot added this to the 2026.3 milestone May 29, 2026
@github-actions github-actions Bot requested a deployment to snapshot May 29, 2026 02:17 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants