Pressing Apply button in mag settings panel should keep params in memory even if Discard button is then pressed#20236
Merged
Conversation
…ory even if Discard button is then pressed.
5 tasks
seanbudd
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #20235
Fix-up of #20050
Summary of the issue:
When pressing apply in Magnifier settings panel, the values were not kept in memory. Thus, if dialog was then discarded, the initial values memorized when the dialog was opened were restored instead of the ones after Aply has been pressed.
Description of user facing changes:
When Mag settings dialog is discarded, the values of parameters present in the dialog when Apply was pressed are now restored as expected.
Description of developer facing changes:
N/A
Description of development approach:
Updated the *initially variables when settings panel is saved, i.e. when Apply or OK are pressed.
For OK, this has no impact since the dialog is closed.
Testing strategy:
Manual tests: STR of #20235
Known issues with pull request:
None
Code Review Checklist: