Skip to content

Pressing Apply button in mag settings panel should keep params in memory even if Discard button is then pressed#20236

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:applyMagSettings
May 29, 2026
Merged

Pressing Apply button in mag settings panel should keep params in memory even if Discard button is then pressed#20236
seanbudd merged 1 commit into
nvaccess:betafrom
CyrilleB79:applyMagSettings

Conversation

@CyrilleB79

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #20235

Fix-up of #20050

Summary of the issue:

When pressing apply in Magnifier settings panel, the values were not kept in memory. Thus, if dialog was then discarded, the initial values memorized when the dialog was opened were restored instead of the ones after Aply has been pressed.

Description of user facing changes:

When Mag settings dialog is discarded, the values of parameters present in the dialog when Apply was pressed are now restored as expected.

Description of developer facing changes:

N/A

Description of development approach:

Updated the *initially variables when settings panel is saved, i.e. when Apply or OK are pressed.
For OK, this has no impact since the dialog is closed.

Testing strategy:

Manual tests: STR of #20235

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

…ory even if Discard button is then pressed.
@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 28, 2026 14:22
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 28, 2026 14:22
@CyrilleB79 CyrilleB79 requested a review from SaschaCowley May 28, 2026 14:22
@seanbudd seanbudd merged commit 76472d6 into nvaccess:beta May 29, 2026
39 checks passed
@github-actions github-actions Bot added this to the 2026.3 milestone May 29, 2026
@CyrilleB79 CyrilleB79 deleted the applyMagSettings branch May 29, 2026 15:37
@seanbudd seanbudd modified the milestones: 2026.3, 2026.2 Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants