Conversation
…on (#20203) See actions/runner-images#14017 Summary of the issue: GitHub Actions will migrate the windows-2025 (and windows-latest) image label to default to Visual Studio 2026 instead of VS2022. The rollout begins June 8, 2026 and completes June 15, 2026 (actions/runner-images#14017). Any workflow still using windows-2025 after that date will silently switch to VS2026 without prior testing. Description of user facing changes: None. Description of developer facing changes: NVDA is now built with Visual Studio 2026. All CI workflows use the windows-2025-vs2026 runner image label instead of windows-2025, opting in ahead of GitHub's forced migration (June 8–15, 2026) to catch any VS2026 incompatibilities early. Note: this PR can be reverted once GitHub completes the migration (expected June 15, 2026), at which point windows-2025 and windows-2025-vs2026 will be equivalent and the explicit label is no longer needed. It is possible that GitHub eventually deprecates this label. ON revert, the changelog should stay as is, though. Description of development approach: Runner label changed in 5 workflow files: testAndPublish.yml, codeql.yml, fetch-crowdin-translations.yml, add-new-language.yml, regenerate_english_userDocs_translation_source.yml.
…026.2 as it is not stable enough yet. (#20206) Fixes #19667 Fixes #19819 Reverts #19672 Summary of the issue: Experimental code was recently added to NVDA (after 2026.1) that caused the 32 bit synthDriver shim to send its audio back to NvDA for playing, rather than playing it directly in its own process. This was done to test / prepare for the time when add-ons would be running in an app container, and therefore probably would not have direct access to the audio device. However, currently this code is still quite unstable, causing NVDA to freeze when rapidly changing the speech rate, or arrowing up and down in lists, when using sapi4 or 32 bit sapi5. This instability is most likely a similar issue to what was fixed in pr #19609, where RPYC is handoing the return of a call on the wrong thread. But in this case, it is calls to/from nvwave in NVDA's process. Description of user facing changes: Description of developer facing changes: Description of development approach: Simply instruct the synthDriver process not to install the nvwave proxy that brokers back to NvDA. Reverts Re-enable audio ducking for proxied x86 speech synths #19672 so that 32 bit synthDrivers suspend audioDucking while they are running, as audioDucking cnanot be supported without brokering audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.