Use windows-2025-vs2026 runner image ahead of GitHub's VS2026 migration#20203
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates NVDA’s build and CI configuration to use a newer Windows/Visual Studio toolchain, and records the change in user-facing release notes.
Changes:
- Document that NVDA is now built with Visual Studio 2026.
- Update GitHub Actions workflows to run on a new Windows runner label (
windows-2025-vs2026). - Adjust workflow runner configuration metadata (
defaultRunner,supportedRunners).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Adds a release note about building with Visual Studio 2026. |
| .github/workflows/testAndPublish.yml | Switches default/supported runner labels to windows-2025-vs2026. |
| .github/workflows/regenerate_english_userDocs_translation_source.yml | Moves workflow execution to windows-2025-vs2026. |
| .github/workflows/fetch-crowdin-translations.yml | Moves workflow execution to windows-2025-vs2026. |
| .github/workflows/codeql.yml | Moves CodeQL analysis job to windows-2025-vs2026. |
| .github/workflows/add-new-language.yml | Moves workflow execution to windows-2025-vs2026. |
VS2026 becomes default on windows-2025 images; switch proactively to avoid surprise breakage. See actions/runner-images#14017.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
See actions/runner-images#14017
Summary of the issue:
GitHub Actions will migrate the
windows-2025(andwindows-latest) image label to default to Visual Studio 2026 instead of VS2022. The rollout begins June 8, 2026 and completes June 15, 2026 (actions/runner-images#14017). Any workflow still usingwindows-2025after that date will silently switch to VS2026 without prior testing.Description of user facing changes:
None.
Description of developer facing changes:
NVDA is now built with Visual Studio 2026. All CI workflows use the
windows-2025-vs2026runner image label instead ofwindows-2025, opting in ahead of GitHub's forced migration (June 8–15, 2026) to catch any VS2026 incompatibilities early.Note: this PR can be reverted once GitHub completes the migration (expected June 15, 2026), at which point
windows-2025andwindows-2025-vs2026will be equivalent and the explicit label is no longer needed. It is possible that GitHub eventually deprecates this label. ON revert, the changelog should stay as is, though.Description of development approach:
Runner label changed in 5 workflow files:
testAndPublish.yml,codeql.yml,fetch-crowdin-translations.yml,add-new-language.yml,regenerate_english_userDocs_translation_source.yml.Testing strategy:
Known issues with pull request:
None — surfacing VS2026 breakage early is the point.
Code Review Checklist: