Skip to content

beta to master#20190

Merged
seanbudd merged 4 commits into
masterfrom
beta
May 21, 2026
Merged

beta to master#20190
seanbudd merged 4 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

No description provided.

seanbudd and others added 4 commits May 20, 2026 16:07
**Must be a squash merge**

Changes from this PR to the previous release:
- Files to check: `user_docs/en/userGuide.md`, `user_docs/en/changes.md`
`developerGuide.md`
- [Compare this branch to the previous
release](https://github.com/nvaccess/nvda/compare/release-2026.1.1rc1...docs2026.2?expand=1)
- Comparison command:
`git diff rrelease-2026.1.1rc1...docs2026.2 -- "**/en/*.md"
"**/developerGuide.md"`

Common mistakes to check for:
- Issue/PR reference in changes file is incorrect
- Incorrect spelling.
- Shortcuts added without code markdown (e.g. `NVDA+d`)
- List items not indented by a multiple of 2 spaces (regex `^ (  )*\*`)
- Double spaces (regex `[^ ]  `)
- Inconsistent use of single vs double quote. (regex `' `)

---------

Co-authored-by: WMHN <1872265132@qq.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Quentin Christensen <quentin@nvaccess.org>
Closes #20125
(discussion)

Follow-up of #19966
Summary of the issue:

The log level with unredacted secrets was called "secrets". This name was not found to be the most suitable.
Description of user facing changes:

The lower log level with unredacted secrets is now called "debug (unredacted)"

People running alpha / beta who have saved SECRET level as their logging level will have their logging level unrecognized and restored to default (INFO). This is acceptable during alpha/beta phase.
Description of developer facing changes:

N/A
Description of development approach:

    Updated code.
    I have not implemented a config upgrade from SECRET to DEBUG_UNREDACTED, since the drawback (level restored to INFO) is acceptable during alpha/beta phase; and implementing a config upgrade step would add just more code to avoid a not very penalizing issue for alpha / early beta tester.
…#20139)

Fixes #19486
Summary of the issue:

    the magnifier zoom level is capped at 10x, which quite low
    the dropdown list of zoom in settings is quite awkward, particularly with more options

Description of user facing changes:

    higher zoom value (50x/5000%)
    zoom is a percentage now
    the zoom setting is a spin control rather than a drop down.

Description of developer facing changes:

Added a StepSpinCtrl that allows step values for integer spin controls
Description of development approach:

    Use integer zoom percentage values as wx.spinctrldouble is inaccessible
Fix #20148
Summary of the issue:

If the magnifier failed to start (E.g. if screen curtain or win mag was running), the enabled state was still set to True
Description of user facing changes:

magnifier state now accurately reflects if magnifier failed to start
Description of developer facing changes:

none
Description of development approach:

check if running when setting state
@seanbudd seanbudd requested a review from a team as a code owner May 21, 2026 04:36
Copilot AI review requested due to automatic review settings May 21, 2026 04:36
@seanbudd seanbudd requested a review from a team as a code owner May 21, 2026 04:36
@seanbudd seanbudd merged commit b30df39 into master May 21, 2026
22 of 24 checks passed
@github-actions github-actions Bot added this to the 2026.3 milestone May 21, 2026
@github-actions github-actions Bot requested a deployment to snapshot May 21, 2026 04:50 Abandoned
@seanbudd seanbudd review requested due to automatic review settings May 21, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants