Skip to content

Change Secrets logging level name to Debug (unredacted)#20173

Merged
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:chgSecretsName
May 20, 2026
Merged

Change Secrets logging level name to Debug (unredacted)#20173
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:chgSecretsName

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #20125
(discussion)

Follow-up of #19966

Summary of the issue:

The log level with unredacted secrets was called "secrets". This name was not found to be the most suitable.

Description of user facing changes:

The lower log level with unredacted secrets is now called "debug (unredacted)"

People running alpha / beta who have saved SECRET level as their logging level will have their logging level unrecognized and restored to default (INFO). This is acceptable during alpha/beta phase.

Description of developer facing changes:

N/A

Description of development approach:

  • Updated code.
  • I have not implemented a config upgrade from SECRET to DEBUG_UNREDACTED, since the drawback (level restored to INFO) is acceptable during alpha/beta phase; and implementing a config upgrade step would add just more code to avoid a not very penalizing issue for alpha / early beta tester.

Testing strategy:

  • Unit tests
  • manual tests

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd changed the base branch from master to beta May 19, 2026 08:01
@seanbudd seanbudd added this to the 2026.2 milestone May 19, 2026
@seanbudd

Copy link
Copy Markdown
Member

Please make sure to rebase on beta thanks

@CyrilleB79 CyrilleB79 mentioned this pull request May 19, 2026
5 tasks
@CyrilleB79 CyrilleB79 force-pushed the chgSecretsName branch 2 times, most recently from 47cce83 to a1ccaaa Compare May 20, 2026 06:10
@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 20, 2026 07:05
@CyrilleB79 CyrilleB79 requested review from a team as code owners May 20, 2026 07:05
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Note: initial description slightly updated.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well

@seanbudd seanbudd merged commit 4ca62b8 into nvaccess:beta May 20, 2026
33 of 35 checks passed
@CyrilleB79 CyrilleB79 deleted the chgSecretsName branch May 20, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants