Change Secrets logging level name to Debug (unredacted)#20173
Merged
Conversation
Member
|
Please make sure to rebase on beta thanks |
47cce83 to
a1ccaaa
Compare
a1ccaaa to
30e9737
Compare
Contributor
Author
|
Note: initial description slightly updated. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20125
(discussion)
Follow-up of #19966
Summary of the issue:
The log level with unredacted secrets was called "secrets". This name was not found to be the most suitable.
Description of user facing changes:
The lower log level with unredacted secrets is now called "debug (unredacted)"
People running alpha / beta who have saved SECRET level as their logging level will have their logging level unrecognized and restored to default (INFO). This is acceptable during alpha/beta phase.
Description of developer facing changes:
N/A
Description of development approach:
Testing strategy:
Known issues with pull request:
None
Code Review Checklist: