Skip to content

Fix secrets logging#20174

Merged
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:fixSecrets
May 19, 2026
Merged

Fix secrets logging#20174
seanbudd merged 2 commits into
nvaccess:betafrom
CyrilleB79:fixSecrets

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Found while testing #20173

Link to issue number:

Fix-up of #19966

Summary of the issue:

#19966 introduces secrets logging level. Though, manually testing, we can see that secrets are never masked, no matter the log level.

Description of user facing changes:

Secrets are now masked in log for log levels higher than "secrets".

Description of developer facing changes:

N/A

Description of development approach:

Testing strategy:

Manual tests at "debug" and "secrets" levels.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review May 19, 2026 10:26
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner May 19, 2026 10:26
@CyrilleB79 CyrilleB79 requested a review from seanbudd May 19, 2026 10:26
@wmhn1872265132

Copy link
Copy Markdown
Contributor

Since this is a fix, shouldn't it be merged into the beta branch?

@CyrilleB79 CyrilleB79 changed the base branch from master to beta May 19, 2026 12:09
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Yes, thanks @wmhn1872265132! I have rebased now.

@seanbudd seanbudd added this to the 2026.2 milestone May 19, 2026
@seanbudd seanbudd merged commit d6219ab into nvaccess:beta May 19, 2026
37 of 39 checks passed
@CyrilleB79 CyrilleB79 deleted the fixSecrets branch May 20, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants