Fix secrets logging#20174
Merged
Merged
Conversation
Contributor
|
Since this is a fix, shouldn't it be merged into the beta branch? |
added 2 commits
May 19, 2026 14:10
Contributor
Author
|
Yes, thanks @wmhn1872265132! I have rebased now. |
seanbudd
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing #20173
Link to issue number:
Fix-up of #19966
Summary of the issue:
#19966 introduces secrets logging level. Though, manually testing, we can see that secrets are never masked, no matter the log level.
Description of user facing changes:
Secrets are now masked in log for log levels higher than "secrets".
Description of developer facing changes:
N/A
Description of development approach:
INFOinstead ofNOTSET.Testing strategy:
Manual tests at "debug" and "secrets" levels.
Known issues with pull request:
None
Code Review Checklist: