Skip to content

modify zoom command to start magnifier if not running#19954

Merged
seanbudd merged 7 commits into
nvaccess:masterfrom
ethanl-11:magnifierStartWithZoom
Apr 24, 2026
Merged

modify zoom command to start magnifier if not running#19954
seanbudd merged 7 commits into
nvaccess:masterfrom
ethanl-11:magnifierStartWithZoom

Conversation

@ethanl-11

@ethanl-11 ethanl-11 commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #19624

Summary of the issue:

Magnifier does not match Windows Magnifier behavior. Attempting to "zoom in" with NVDA+shift+plus while magnifier is not running results in a warning rather than starting the magnifier.

Description of user facing changes:

NVDA+shift+plus can now start the magnifier if it wasn't previously running. Keyset continues to serve as a "zoom in" command once magnifier is running.

Description of developer facing changes:

None.

Description of development approach:

A check has been added to the zoom function in commands.py that will call toggleMagnifier() if the magnifier is not already active and the zoom direction is positive. Otherwise, zoom behaves as expected.

Testing strategy:

Run changes locally to manually confirm NVDA+shift+plus will start magnifier and ensure zoom functionality is unchanged once magnifier is running.
Unit tests were also added.

Known issues with pull request:

N/A.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@ethanl-11

ethanl-11 commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The lint and license checks found a few errors, but they didn't seem to be related to the files I changed/added. I only added the two files i actually changed to be safe. There was one CI test that seemed to be failing testing the PR in my own fork, but that is not repeated here.

@ethanl-11 ethanl-11 marked this pull request as ready for review April 17, 2026 23:03
@ethanl-11 ethanl-11 requested a review from a team as a code owner April 17, 2026 23:03
@ethanl-11 ethanl-11 requested a review from SaschaCowley April 17, 2026 23:03
@Qchristensen

Qchristensen commented Apr 20, 2026

Copy link
Copy Markdown
Member

Should this also incorporate an update to the User Guide to confirm that NVDA+shift+equals enables the magnifier (both in the "Enabling and Disabling the Magnifier" section, and the "Magnifier controls" table blow that)

Perhaps simply a sentence after "To enable or disable the magnifier, press NVDA+shift+w. " to read something like:

The "Increase magnification level" keystroke, NVDA+shift+equals, will start the magnifier if it is not running.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 20, 2026
seanbudd
seanbudd reviewed Apr 21, 2026
View reviewed changes
Comment thread tests/unit/test_magnifier/test_magnifierCommands.py Outdated
@seanbudd seanbudd marked this pull request as draft April 21, 2026 23:18
@seanbudd

seanbudd commented Apr 21, 2026

Copy link
Copy Markdown
Member

@ethanl-11 - please also update the user guide as suggested, to ensure references to the zoom command cover the new behaviour

@ethanl-11 ethanl-11 marked this pull request as ready for review April 22, 2026 22:08
@ethanl-11 ethanl-11 requested a review from a team as a code owner April 22, 2026 22:08
@ethanl-11 ethanl-11 requested a review from Qchristensen April 22, 2026 22:08
seanbudd
seanbudd reviewed Apr 24, 2026
View reviewed changes
Comment thread user_docs/en/userGuide.md Outdated
seanbudd
seanbudd approved these changes Apr 24, 2026
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ethanl-11

Qchristensen
Qchristensen approved these changes Apr 24, 2026
View reviewed changes

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well

@seanbudd seanbudd enabled auto-merge (squash) April 24, 2026 01:39
@seanbudd seanbudd disabled auto-merge April 24, 2026 02:18
@seanbudd seanbudd merged commit 605fe47 into nvaccess:master Apr 24, 2026
65 of 69 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Apr 24, 2026
@ethanl-11

ethanl-11 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for helping me get this through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@Qchristensen Qchristensen Qchristensen approved these changes

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2026.2

Development

Successfully merging this pull request may close these issues.

Start magnifier and zoom when pressing zoom key and magnifier not started

3 participants

@ethanl-11 @Qchristensen @seanbudd