Closes nvaccess#16799
Summary of the issue:

The scons tests command only ran translation string comment checks (equivalent to scons checkPot), which was misleading since users expected it to run all tests.
Description of user facing changes:

None.
Description of developer facing changes:

The scons tests build target has been removed. Running scons tests now produces an explicit error message directing users to the correct commands:

    scons checkPot for translation string checks
    rununittests.bat for unit tests
    runsystemtests.bat for system tests
    runlint.bat for linting

Description of development approach:

    Removed the tests/sconscript file that defined the misleading tests target.
    Inlined the checkPot target definition from tests/sconscript into the main sconstruct file.
    Added an explicit tests alias that raises SCons.Errors.UserError with a helpful error message, preventing SCons from silently succeeding due to the existing tests/ directory.

Remove the checkPot target from sconstruct and provide a standalone
runcheckpot.bat script that calls scons pot then validates the output
with tests/checkPot.py. This follows up on PR nvaccess#19606 review feedback
to stop using SCons for checkPot entirely.

Also fixes tests/checkPot.py __main__ to call sys.exit() with the
error count so exit codes propagate correctly when run standalone.

Remove the checkPot target from sconstruct and provide a standalone
runcheckpot.bat script that calls scons pot then validates the output
with tests/checkPot.py. This follows up on PR nvaccess#19606 review feedback
to stop using SCons for checkPot entirely.

Also fixes tests/checkPot.py __main__ to call sys.exit() with the
error count so exit codes propagate correctly when run standalone.

Remove the checkPot target from sconstruct and provide a standalone
runcheckpot.bat script that calls scons pot then validates the output
with tests/checkPot.py. This follows up on PR nvaccess#19606 review feedback
to stop using SCons for checkPot entirely.

Also fixes tests/checkPot.py __main__ to call sys.exit() with the
error count so exit codes propagate correctly when run standalone.

Link to issue number:

N/A
Summary of the issue:

scons checkPot is more a utility and not really part of the build. Having a separate runcheckpot.bat is consistent with other utilities like rununittests or runlint. This has been suggested in a comment on PR #19606. Since that PR was already merged, this change is done in this new PR.
Description of user facing changes:

None
Description of developer facing changes:

The scons checkPot command has been replaced with runcheckpot.bat. This script generates the pot file via scons pot, then runs tests/checkPot.py directly on the output. Any arguments (e.g. --all-cores, -j 1) are forwarded to the scons pot invocation. Since we need an up-to-date pot file to run checks and generating that file is part of the SCons build, we still have the overhead of calling SCons when running runcheckpot.bat.
Description of development approach:

    Created runcheckpot.bat following the naming and structure conventions of existing bat files (rununittests.bat, runlicensecheck.bat, etc.).
    Removed the checkPot target, action, and alias from sconstruct (the pot target is unchanged).
    Updated the pre-commit hook from language: system (invoking cmd.exe /c "scons checkPot") to language: script (invoking ./runcheckpot.bat), matching how other bat-based hooks are configured.
    Updated ci/scripts/tests/translationCheck.ps1 to call runcheckpot.bat.
    Fixed tests/checkPot.py __main__ block to call sys.exit() with the error count. Previously it only printed the count, which meant standalone invocation always exited 0 regardless of errors. This was not a problem when SCons used the return
    value directly, but is critical now that the script is invoked via bat file.
    Updated developer documentationchangelog entry.