Skip to content

Remove unused languages added along with MathCAT inclusion#19484

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:remLang
Jan 22, 2026
Merged

Remove unused languages added along with MathCAT inclusion#19484
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:remLang

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Link to issue number:

Asked / accepted by @seanbudd in https://github.com/CyrilleB79/nvda/pull/new/remLang

Summary of the issue:

When MathCAT has been integrated in NVDA (#18323), many translatable language names have been added. These language names are not used by MathCAT, nor by NVDA itself. Thus this addition only represents extra work for translators and unused code in the code base.

Description of user facing changes:

N/A

Description of developer facing changes:

No more unused languages to translate.

Description of development approach:

Testing strategy:

Launch NVDA and check that the language list of General settings and MathCAT remain available and translated.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review January 21, 2026 21:17
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner January 21, 2026 21:17
@seanbudd seanbudd merged commit ccdd960 into nvaccess:master Jan 22, 2026
39 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Jan 22, 2026
@wmhn1872265132

wmhn1872265132 commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

It seems this PR should be merged into beta to ensure these language names will not be translated during 2026.1

@seanbudd

seanbudd commented Jan 22, 2026

Copy link
Copy Markdown
Member

Thanks for catching this @wmhn1872265132 - @CyrilleB79 can you cherry-pick this to beta?

@CyrilleB79 CyrilleB79 mentioned this pull request Jan 22, 2026
Merged
5 tasks
seanbudd pushed a commit that referenced this pull request Jan 22, 2026
@CyrilleB79
Remove unused languages added along with MathCAT inclusion - Cherry-p…
8bfb0e5 
…ick for beta (#19488)

ollow-up of #19484
Summary of the issue:

#19484 has been merged to master, while the goal was to merge it in beta. This PR is a cherry-pick of #19484 in beta branch.
Description of user facing changes:

N/A
Description of developer facing changes:

See #19484
@CyrilleB79

CyrilleB79 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

It seems this PR should be merged into beta to ensure these language names will not be translated during 2026.1

Thanks @wmhn1872265132 for catching this.
It was a mistake of mine: I intended to target beta but targeted master instead. The issue is now fixed in beta too.

@CyrilleB79 CyrilleB79 deleted the remLang branch January 22, 2026 09:22
@nvdaes nvdaes mentioned this pull request Apr 11, 2026
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

@SaschaCowley SaschaCowley Awaiting requested review from SaschaCowley SaschaCowley is a code owner automatically assigned from nvaccess/developers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2026.2

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrilleB79 @wmhn1872265132 @seanbudd