Skip to content

Add new language km from Crowdin#19458

Merged
seanbudd merged 1 commit into
betafrom
addLanguage_km21120319891
Jan 18, 2026
Merged

Add new language km from Crowdin#19458
seanbudd merged 1 commit into
betafrom
addLanguage_km21120319891

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds km as a new language to track from Crowdin.

@github-actions github-actions Bot requested a review from a team as a code owner January 18, 2026 23:23
@github-actions github-actions Bot requested a review from seanbudd January 18, 2026 23:24
@github-actions github-actions Bot enabled auto-merge (squash) January 18, 2026 23:24
@seanbudd seanbudd disabled auto-merge January 18, 2026 23:24
@seanbudd seanbudd merged commit 372052c into beta Jan 18, 2026
1 check was pending
@seanbudd seanbudd deleted the addLanguage_km21120319891 branch January 18, 2026 23:24
@github-actions github-actions Bot added this to the 2026.2 milestone Jan 18, 2026
@seanbudd seanbudd mentioned this pull request Jan 18, 2026
5 tasks
@seanbudd seanbudd modified the milestones: 2026.2, 2026.1 Jan 18, 2026
seanbudd added a commit that referenced this pull request Jan 19, 2026
was blocked by #19426 and #19458
Summary of the issue:

#19458 introduced Cambodian, but we need to document it's support in NVDA

Additionally, unit tests are temporarily broken by #19458 causing an issue, with python/cpython#123853 as the root cause
Description of user facing changes:

Document cambodian support
Description of developer facing changes:

None
Description of development approach:

    Introduced _LCIDS_TO_TRANSLATED_LOCALES_OVERRIDES in languageHandler.py to correctly map the Windows LCID for Khmer (Cambodian), addressing upstream issues in Python's locale mapping. [1] [2]
    Refactored type annotations throughout languageHandler.py to use modern Python syntax (e.g., str | None instead of Optional[str], list[str] instead of List[str]). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant