Remove SAPI4#19290
Merged
Merged
Conversation
seanbudd
approved these changes
Nov 27, 2025
5 tasks
michaelDCurran
added a commit
that referenced
this pull request
Jan 13, 2026
This reverts commit 33cf7ad.
michaelDCurran
added a commit
that referenced
this pull request
Jan 14, 2026
…it to the 32 bit runtime (#19436) ### Link to issue number: <!-- Use Closes/Fixes/Resolves #xxx to link this PR to the issue it is responding to. --> Reverts #19290 ### Summary of the issue: with the move to 64 bit, sapi4 became unusable as it only functions in a 32 bit process. PR #19290 was merged which removes sapi4. However, pr #19432 is adding the infrastructure to run sapi4 within a 32 bit runtime. Thus the original sapi4 should be tempoararily added back so that pr #19432 can move it into its 32 bit location. ### Description of user facing changes: None. ### Description of developer facing changes: ### Description of development approach: This is a clean revert of pr #19290 (with only a conflict in changes.md which was addressed). ### Testing strategy: None - clean revert. ### Known issues with pull request: None known. ### Code Review Checklist: <!-- This checklist is a reminder of things commonly forgotten in a new PR. Authors, please do a self-review of this pull-request. Check items to confirm you have thought about the relevance of the item. Where items are missing (eg unit / system tests), please explain in the PR. To check an item `- [ ]` becomes `- [x]`, note spacing. You can also check the checkboxes after the PR is created. A detailed explanation of this checklist is available here: https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md#code-review-checklist --> - [x] Documentation: - Change log entry - User Documentation - Developer / Technical Documentation - Context sensitive help for GUI changes - [x] Testing: - Unit tests - System (end to end) tests - Manual testing - [x] UX of all users considered: - Speech - Braille - Low Vision - Different web browsers - Localization in other languages / culture than English - [x] API is compatible with existing add-ons. - [x] Security precautions taken. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18310
Closes #19030
Closes #17964
Summary of the issue:
SAPI4 is 32-bit only. As we don't currently have a SAPI4 bridge or a compatibility shim, we need to remove support.
Description of user facing changes:
SAPI4 speech synthesizers are no longer supported by NVDA.
Description of developer facing changes:
SAPI4 and related code has been removed.
Description of development approach:
Deleted the synth drivers and related code.
Testing strategy:
System and usage tests.
Tried changing synthesizers to ensure that things still work as expected.
Known issues with pull request:
This may stop some users from using their preferred speech synthesizer. For many users, this is a luxury, however for some a SAPI4 synth may be a necessity, due to language, hearing, auditory processing issues etc.
Code Review Checklist: