Ensure multiselectable is discarded for TableCell#19247
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes issue #19242 where NVDA was incorrectly reporting "multiselectable" for every table cell in LibreOffice Calc. The fix consolidates the logic for discarding the MULTISELECTABLE state and adds TABLECELL to the list of roles where this state should be suppressed. Additionally, the settings documentation and UI text are updated from "lists" to "objects" to better reflect that the setting affects multiple object types, not just lists.
Key Changes
- Consolidated MULTISELECTABLE state discarding logic into a single conditional block that includes TABLECELL role
- Updated user documentation and GUI settings text to refer to "objects" instead of "lists" for the multiselect reporting option
- Modernized type hints and docstring style for the
_processPositiveStatesfunction
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Updated documentation to refer to "objects" instead of "lists" for the multiselectable reporting setting, making it more general and accurate |
| source/gui/settingsDialogs.py | Updated GUI label text to match documentation changes, replacing "lists" with "objects" |
| source/controlTypes/processAndLabelStates.py | Consolidated MULTISELECTABLE state discarding logic and added TABLECELL role; also updated type hints to modern Python syntax and docstring style to Sphinx/reStructuredText format for one function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19242
Summary of the issue:
NVDA was reporting multieselectable for every table cell in Libre Office Calc.
Description of user facing changes:
Description of developer facing changes:
None
Description of development approach:
Simplified code for discarding into a single separate if branch that also includes table cells.
Testing strategy:
Tested in Libre Office calc.
Known issues with pull request:
None
Code Review Checklist: