Skip to content

Excel legacy now reports Has note#19161

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:excelHasNote
Nov 4, 2025
Merged

Excel legacy now reports Has note#19161
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:excelHasNote

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #18709
Follow-up of #11311

Summary of the issue:

In Excel (legacy), when entering a cell with a note, Excel reports "Has comment". This is confusing since there are new threaded comment types in newer Excel versions.

It was listed as a known issue of #11311.

It's worth noting that with Excel UIA, NVDA already reports "Has note" in this case.

Description of user facing changes:

When moving the focus on a cell with a note, Excel now reports "Has note". It is consistent with NVDA's interface and User Guide which mention note everywhere else.

Description of developer facing changes:

N/A

Description of development approach:

Use the new HASNOTE state introduced since then instead of the HASCOMMENT state, as done for UIA.

Testing strategy:

Manual check that "has note" is reported with cells having a note on:

  • Excel 2021 LTSC, without collaborative threaded comments
  • Excel 365, with collaborative threaded comment feature (should be unrelated anyway)

Known issues with pull request:

Excel reports "has note" on older versions where notes were called comments.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner November 3, 2025 15:47
@CyrilleB79 CyrilleB79 requested a review from seanbudd November 3, 2025 15:47
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

@Adriani90 would you mind test this PR with Excel 365 when the build is ready (or from source)?

@seanbudd seanbudd merged commit a6a536e into nvaccess:master Nov 4, 2025
29 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Nov 4, 2025
@CyrilleB79 CyrilleB79 deleted the excelHasNote branch November 7, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Excel, NVDA reports "Has comment" when a cell has a note. NVDA should report "Has note" instead

2 participants