Excel legacy now reports Has note#19161
Merged
Merged
Conversation
Contributor
Author
|
@Adriani90 would you mind test this PR with Excel 365 when the build is ready (or from source)? |
seanbudd
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18709
Follow-up of #11311
Summary of the issue:
In Excel (legacy), when entering a cell with a note, Excel reports "Has comment". This is confusing since there are new threaded comment types in newer Excel versions.
It was listed as a known issue of #11311.
It's worth noting that with Excel UIA, NVDA already reports "Has note" in this case.
Description of user facing changes:
When moving the focus on a cell with a note, Excel now reports "Has note". It is consistent with NVDA's interface and User Guide which mention note everywhere else.
Description of developer facing changes:
N/A
Description of development approach:
Use the new
HASNOTEstate introduced since then instead of theHASCOMMENTstate, as done for UIA.Testing strategy:
Manual check that "has note" is reported with cells having a note on:
Known issues with pull request:
Excel reports "has note" on older versions where notes were called comments.
Code Review Checklist: