Fix uploading of symbols to Mozilla.#19130
Merged
Merged
Conversation
jcsteh
commented
Oct 23, 2025
bramd
pushed a commit
to bramd/nvda
that referenced
this pull request
Nov 11, 2025
### Summary of the issue: NVDA builds are intended to upload debug symbols to Mozilla. This makes it easier to diagnose issues related to NVDA's in-process code in Firefox (both crash analysis and profiling), which helps both projects. Unfortunately, this broke years ago for various reasons. ### Description of user facing changes: None. ### Description of developer facing changes: Mozilla crash reports and profiles will show useful symbols for NVDA code. I haven't included a change log entry for NVDA because this doesn't impact NVDA developers normally, only if they're working with Firefox. ### Description of development approach: 1. The version of dump_syms.exe in miscDeps from Google Breakpad is very outdated and probably no longer works. Mozilla completely rewrote this a few years ago. Download that from GitHub releases and use that instead. 2. mozillaSyms.py uses relative paths, but the script was moved in bd6b99e, which broke these paths. Update the script accordingly. 3. The structure of NVDA's lib directory has changed significantly in the last few years. Furthermore, NVDA now supports more architectures (arm64, arm64ec). Update mozillaSyms.py accordingly. 4. Remove some unnecessary actions from the uploadSymbols CI job. ### Testing strategy: Confirmed that [symbols were uploaded successfully in a try run](https://github.com/nvaccess/nvda/actions/runs/18735136393/job/53440453068). ### Known issues with pull request: None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
NVDA builds are intended to upload debug symbols to Mozilla. This makes it easier to diagnose issues related to NVDA's in-process code in Firefox (both crash analysis and profiling), which helps both projects. Unfortunately, this broke years ago for various reasons.
Description of user facing changes:
None.
Description of developer facing changes:
Mozilla crash reports and profiles will show useful symbols for NVDA code.
I haven't included a change log entry for NVDA because this doesn't impact NVDA developers normally, only if they're working with Firefox.
Description of development approach:
Testing strategy:
Confirmed that symbols were uploaded successfully in a try run.
Known issues with pull request:
None.
Code Review Checklist: