Skip to content

Merge beta to master#19124

Merged
SaschaCowley merged 5 commits into
masterfrom
beta
Oct 20, 2025
Merged

Merge beta to master#19124
SaschaCowley merged 5 commits into
masterfrom
beta

Conversation

@SaschaCowley

Copy link
Copy Markdown
Member

No description provided.

seanbudd and others added 5 commits October 14, 2025 17:18
### Summary of the issue:

A recent update to chrome has introduced a "Ask Google about this page"
option in the omnibox (address bar). This option is sometimes spoken,
even though it isn't focused, when focusing the address bar. This causes
system tests which rely on Chrome to fail, as they are unable to
recognise that the address bar has been focused.
This breaks some tests in the Chrome, symbols, and image descriptions
system test suites.

### Description of user facing changes:

None.

### Description of developer facing changes:

System tests work again.

### Description of development approach:

When setting up a system test that uses Chrome, after sending `alt+d` to
focus the address bar, if the speech is not what we expect, try
reporting the focused object (`NVDA+tab`) to double-check.
This works because "Address and search bar" speech is cancelled by the
"Ask Google about this page" speech, so the system tests are unaware
where the focus has landed. By explicitly checking the current focus, we
work around this issue.

### Testing strategy:

Ran the Chrome system test "checkbox labelled by inner element" locally,
with and without this patch, to ensure that it was broken on my machine
without the patch, and fixed with it.
Ran in CI.

### Known issues with pull request:

This does not fix the underlying issue, which will still likely
inconvenience users. However, as this is stopping us being able to
create snapshot, beta, rc or release builds, this fix needed to be
prioritised.
Merge RC to beta
@SaschaCowley SaschaCowley requested a review from a team as a code owner October 20, 2025 21:35
@SaschaCowley SaschaCowley requested review from Copilot and seanbudd and removed request for Copilot October 20, 2025 21:35
@SaschaCowley SaschaCowley merged commit c1ba1a2 into master Oct 20, 2025
9 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants