Fix Chrome system tests#19121
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Chrome system tests that were failing due to a recent Chrome update introducing an "Ask Google about this page" option that interferes with address bar focus detection. The fix implements a fallback mechanism to double-check focus when the expected speech output isn't detected.
- Adds workaround logic to detect when Chrome's new omnibox option interferes with expected speech
- Implements fallback focus reporting using
NVDA+tabwhen address bar speech is clobbered - Fixes trailing comma formatting issues in error logging statements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/system/libraries/ChromeLib.py | Adds fallback logic to handle Chrome's interfering "Ask Google" speech output |
| source/_remoteClient/secureDesktop.py | Fixes missing trailing commas in f-string log statements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8ba828d to
3827e21
Compare
michaelDCurran
approved these changes
Oct 20, 2025
15e2cd1 to
69ce565
Compare
74a7943 to
e5f0107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
A recent update to chrome has introduced a "Ask Google about this page" option in the omnibox (address bar). This option is sometimes spoken, even though it isn't focused, when focusing the address bar. This causes system tests which rely on Chrome to fail, as they are unable to recognise that the address bar has been focused.
This breaks some tests in the Chrome, symbols, and image descriptions system test suites.
Description of user facing changes:
None.
Description of developer facing changes:
System tests work again.
Description of development approach:
When setting up a system test that uses Chrome, after sending
alt+dto focus the address bar, if the speech is not what we expect, try reporting the focused object (NVDA+tab) to double-check.This works because "Address and search bar" speech is cancelled by the "Ask Google about this page" speech, so the system tests are unaware where the focus has landed. By explicitly checking the current focus, we work around this issue.
Testing strategy:
Ran the Chrome system test "checkbox labelled by inner element" locally, with and without this patch, to ensure that it was broken on my machine without the patch, and fixed with it.
Ran in CI.
Known issues with pull request:
This does not fix the underlying issue, which will still likely inconvenience users. However, as this is stopping us being able to create snapshot, beta, rc or release builds, this fix needed to be prioritised..
Code Review Checklist: