Skip to content

Report number of items for lists in braille#19119

Merged
SaschaCowley merged 12 commits into
nvaccess:masterfrom
nvdaes:brailleNumItems
Oct 24, 2025
Merged

Report number of items for lists in braille#19119
SaschaCowley merged 12 commits into
nvaccess:masterfrom
nvdaes:brailleNumItems

Conversation

@nvdaes

@nvdaes nvdaes commented Oct 19, 2025

Copy link
Copy Markdown
Collaborator
  • Report number of items of lists in braille
  • Uncoment code
  • Update changelog
  • Add comment for translators
  • Improve comment for translators

Link to issue number:

Closes #7455

Summary of the issue:

In browse mode documents, the number of ítems for lists is not reported in braille, just via speech output.

Description of user facing changes:

The number of ítems Will be appended to lst for lists in browse mode documents.

Description of developer facing changes:

None

Description of development approach:

Use the _childcontrolcount attribute of text info fields to get the number of ítems of lists, and set the appropriate roleText when the number of ítems of a list is available.

Testing strategy:

Tested locally, checking that the number of ítems is reported for lists in browse mode.

Known issues with pull request:

In rare cases, the number of items can be reported via speech output, not in braille, or in braille, not speech. Here is an example of a webpage where the number of items is reported just via speech. I've observed this just when the list contains 1 element.
In braille, in Spanish, in this webpage, pressing l to reach a list with 1 item, I read the word "fin" (end). This is not read via speech. Seems a non standard control (like an empty list inside a menu):

https://duckduckgo.com/

I've seen, once, that the number of items was reported just in braille, not speech. If I find the webpage I'll include it here.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes nvdaes marked this pull request as ready for review October 19, 2025 11:34
@nvdaes nvdaes requested a review from a team as a code owner October 19, 2025 11:34
@nvdaes nvdaes requested a review from SaschaCowley October 19, 2025 11:34
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 21, 2025
Comment thread source/braille.py Outdated
Comment thread source/braille.py Outdated
Comment thread user_docs/en/changes.md Outdated
@SaschaCowley SaschaCowley marked this pull request as draft October 21, 2025 01:48
@nvdaes nvdaes marked this pull request as ready for review October 21, 2025 04:46
@nvdaes

nvdaes commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator Author

I've observed that, in most cases, speech and braille report the number of items in the same situations. But once I found that this was reported in speech, and in other case, this was reported in braille but not speech. I don't think we can do too much to address that infrequent situations.
Apart of this, @SaschaCowley , I've addressed your comments.

@CyrilleB79

Copy link
Copy Markdown
Contributor

But once I found that this was reported in speech, and in other case, this was reported in braille but not speech.

Can you document it, i.e. provide the situations that you have encountered, so that it can be decided/understood if they can be handled or not? Is it something that occurs sporadically on the same document, or is it linked to a specific document or page web where it would be 100% reproducible?

I don't think we can do too much to address that infrequent situations.

If it is the decision that is finally made, please document it in "Known issues".

@nvdaes

nvdaes commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator Author

@CyrilleB79 , I've updated the section with known issues.

@SaschaCowley SaschaCowley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nvdaes

@SaschaCowley SaschaCowley merged commit 418d22a into nvaccess:master Oct 24, 2025
29 checks passed
@github-actions github-actions Bot added this to the 2026.1 milestone Oct 24, 2025
bramd pushed a commit to bramd/nvda that referenced this pull request Nov 11, 2025
Closes nvaccess#7455

In browse mode documents, the number of ítems for lists is not reported
in braille, just via speech output.

The number of ítems Will be appended to lst for lists in browse mode
documents.

None

Use the _childcontrolcount attribute of text info fields to get the
number of ítems of lists, and set the appropriate roleText when the
number of ítems of a list is available.

Tested locally, checking that the number of ítems is reported for lists
in browse mode.

In rare cases, the number of items can be reported via speech output,
not in braille, or in braille, not speech. Here is an example of a
webpage where the number of items is reported just via speech. I've
observed this just when the list contains 1 element.
In braille, in Spanish, in this webpage, pressing l to reach a list with
1 item, I read the word "fin" (end). This is not read via speech. Seems
a non standard control (like an empty list inside a menu):

https://duckduckgo.com/

I've seen, once, that the number of items was reported just in braille,
not speech. If I find the webpage I'll include it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

report in braille how many items are in a list

4 participants