Revert "Use root certificates when using the add-on store and NVDA remote (#18528)"#19106
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts commit 2fa3658, which introduced Windows root certificate usage via the truststore library for the add-on store and NVDA remote functionality.
- Removes truststore dependency and initialization from core startup
- Reverts to custom certificate handling logic in networking utilities
- Restores original SSL context configuration for remote client connections
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/changes.md | Removes changelog entries about truststore integration and related fixes |
| source/utils/networking.py | Deletes the entire networking utility module that provided truststore-based certificate handling |
| source/updateCheck.py | Restores original certificate update logic and removes truststore-related deprecations |
| source/core.py | Removes truststore initialization from main startup function |
| source/addonStore/network.py | Reverts to simpler download logic without certificate verification handling |
| source/addonStore/dataManager.py | Removes truststore-based networking calls in favor of direct requests |
| source/_remoteClient/transport.py | Restores original SSL context configuration without truststore |
| pyproject.toml | Removes truststore dependency from project requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Can this PR be merged within this week? |
SaschaCowley
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2fa3658.
Reverts PR
Reverts #18528
Issues fixed
Fixes #19076
Issues reopened
Reopens #15905
Reason for revert
Can this PR be reimplemented? If so, what is required for the next attempt