Improvements to battery reporting script#19087
Merged
seanbudd merged 9 commits intoOct 14, 2025
Merged
Conversation
Contributor
|
Thanks for fixing the singular issue; seems that it was my mistake. |
seanbudd
reviewed
Oct 13, 2025
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks for addressing this @hdzrvcc0X74, just some minor suggestions
Contributor
Author
|
@seanbudd Thanks for the feedback! I've implemented your suggestions. This is my first GitHub contribution, so please let me know if I missed anything in the process. |
seanbudd
reviewed
Oct 13, 2025
…m/hdzrvcc0X74/nvda into improvements-to-battery-reporting
Contributor
Author
|
@seanbudd Translator comments added for all new strings. Thanks again for the guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9003.
Summary of the issue:
Battery time script was reporting redundant "0 hours" and "0 minutes", and using plural forms for single hours and minutes.
Description of user facing changes:
NVDA will no longer speak remaining time when it reaches zero, for both hours and minutes.
Description of developer facing changes:
None.
Description of development approach:
Testing strategy:
Manually tested running from source.
Known issues with pull request:
None.
Code Review Checklist: