Conversation
15 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the type checker tooling to use the Node.js-backed Pyright for improved reliability and performance and bumps the version accordingly.
- Switch dev lint dependency to pyright[nodejs]==1.1.406
- Update pre-commit hook to v1.1.406
- Update developer changelog entry
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| user_docs/en/changes.md | Add changelog entry for the Pyright update |
| pyproject.toml | Replace pyright with pyright[nodejs] and bump to 1.1.406 in dev lint dependencies |
| .pre-commit-config.yaml | Bump pyright pre-commit hook to v1.1.406 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17749
Summary of the issue:
#17744 introduced pyright using it's default server nodeenv.
The pyright python package recommends installing pyright[nodejs] for a faster and more reliable server.
Hwever we couldn't use it while NVDA was 32bit.
This is because the node wheel binaries required a 64bit environment.
Now that NVDA has migrated to 64bit, we should update the pyright package version to using nodejs.
Description of user facing changes:
None
Description of developer facing changes:
update pyright
Description of development approach:
update pyright
Testing strategy:
CI/CD
Known issues with pull request:
Pre-commit CI for pyright is broken: RobertCraigie/pyright-python#345
So some of the benefits discussed in #17748 no longer apply
Code Review Checklist: