Remove deprecated code from Remote Access#19077
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated braille display size filtering code from the Remote Access module and replaces it with the newer display dimensions API. The main purpose is to modernize the braille handling to use proper display dimensions while addressing an issue where multi-line braille displays were incorrectly wrapping content.
- Replaces deprecated
braille.filter_displaySizewithbraille.filter_displayDimensions - Updates braille dimension handling to use
numColsinstead ofdisplaySize - Renames and refactors the display size filtering method to handle dimensions properly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/_remoteClient/session.py | Updates braille filtering registration and sendBrailleInfo method to use display dimensions |
| source/_remoteClient/localMachine.py | Refactors display size handling to use numCols and implements proper dimension filtering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
reviewed
Oct 10, 2025
seanbudd
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18831
Summary of the issue:
Remote Access was using the deprecated
braille.filter_displaySizeextension point.It was also using
displaySizeinstead ofdisplayDimensions.numCols, meaning that in the case that a user with a multi-line display was controlling a computer with a single-line display that was wider than the leader's display, braille from the follower would wrap at the width of the leader display. While this would not result in information loss, it was unexpected behaviour.Description of user facing changes:
In remote access sessions where one or more users have multi-line braille displays connected, only the width of these displays will be considered when finding the shared display width. For instance, if leader connects with a DotPad (8x20 cells) and follower connects with a Hims Brailleedge 40 (1x40 cells), the display width for the session will be constrained to 20 cells.
Description of developer facing changes:
None
Description of development approach:
Replace usage of
braill.filter_displaySizewithbraille.filter_displayDimensionsin_remoteClient.session. Also renamed_remoteClient.localMachine.LocalMachine.handleFilterDisplaySizeto_handleFilterDisplayDimensions.Replace usages of
braille.handler.displaySizewithbraille.handler.displayDimension.numColswhere appropriate in_remoteClient.Testing strategy:
Created a session in which the leader was using a DotPad and the follower was using a Brailleedge40.
Known issues with pull request:
Users may desire the existing behaviour of all rows of multi-line displays being considered.
We cannot support multi-line displays over Remote Access without changing the protocol. NV Access does not have a clear policy on when we can change the Remote Access Protocol and in what ways.
Code Review Checklist: