Related issues, PRs or discussions
None that I am aware of.
What is the current state of the codebase?
Currently in the Remote Access session.py, braille.filter_displaySize is used. The log mentions, braille.filter_displaySize is deprecated. Use braille.filter_displayDimensions instead. The relevant section from the log is below.
INFO - _remoteClient.session.RemoteSession.__init__ (07:22:32.409) - MainThread (17776):
Initializing Remote Session
WARNING - extensionPoints.util.HandlerRegistrar.register (07:22:32.411) - MainThread (17776):
braille.filter_displaySize is deprecated. Use braille.filter_displayDimensions instead.
Stack trace:
File "nvda.pyw", line 309, in <module>
File "core.pyc", line 1050, in main
File "wx\core.pyc", line 2262, in MainLoop
File "core.pyc", line 993, in Notify
File "queueHandler.pyc", line 102, in pumpAll
File "queueHandler.pyc", line 67, in flushQueue
File "core.pyc", line 1045, in _doPostNvdaStartupAction
File "extensionPoints\__init__.pyc", line 56, in notify
File "extensionPoints\util.pyc", line 230, in callWithSupportedKwargs
File "_remoteClient\client.pyc", line 102, in performAutoconnect
File "_remoteClient\client.pyc", line 206, in connect
File "_remoteClient\client.pyc", line 376, in connectAsFollower
File "_remoteClient\session.pyc", line 318, in __init__
File "extensionPoints\util.pyc", line 129, in register
Why are changes required?
If this is deprecated as is mentioned by the log, it will likely be removed, which will cause braille display setup in Remote Access to fail, at the minimum.
What technical changes are required?
Replace braille.filter_displaySize with braille.filter_displayDimensions where required.
Are the proposed technical changes API breaking?
Not that I am aware of.
Are there potential risks or issues with the proposed implementation?
None, unless braille.filter_displayDimensions does not perform the same functionality as braille.filter_displaySize
Related issues, PRs or discussions
None that I am aware of.
What is the current state of the codebase?
Currently in the Remote Access session.py, braille.filter_displaySize is used. The log mentions, braille.filter_displaySize is deprecated. Use braille.filter_displayDimensions instead. The relevant section from the log is below.
Why are changes required?
If this is deprecated as is mentioned by the log, it will likely be removed, which will cause braille display setup in Remote Access to fail, at the minimum.
What technical changes are required?
Replace braille.filter_displaySize with braille.filter_displayDimensions where required.
Are the proposed technical changes API breaking?
Not that I am aware of.
Are there potential risks or issues with the proposed implementation?
None, unless braille.filter_displayDimensions does not perform the same functionality as braille.filter_displaySize