Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds discussion category support for prerelease uploads and introduces a new step to upload executable files to release assets for both beta/RC and stable releases.
- Adds
--discussion-category Releasesflag to prerelease publishing to enable GitHub discussions - Introduces a new workflow step to upload exe files to release assets with clobber option
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
@seanbudd none of the code review checklist items are ticked. Is this PR ready for review? |
Member
Author
|
Yep sorry |
SaschaCowley
approved these changes
Aug 18, 2025
OzancanKaratas
pushed a commit
to OzancanKaratas/nvda
that referenced
this pull request
Aug 18, 2025
Part of nvaccess#18556 Summary of the issue: Beta/RC tags do not upload the exe to the release assets, unlike stable releases. Additionally, to make it easier to discuss issues with betas, creating a beta discussion is useful. It also allows us to easily share each new release in slack and other places via Discussions RSS feed. The releases RSS feed includes tags, which duplicates posts to slack. If a build fails due to system tests, you cannot rebuild it as the cache gets deleted. Description of user facing changes: None Description of developer facing changes: GitHub discussions are created for betas and RCs. All releases are auto-posted to slack. The installer artifact is uploaded to the release assets.
seanbudd
added a commit
that referenced
this pull request
Aug 25, 2025
Fixup of #18732 Summary of the issue: The release failed as we were unable to use a star import to upload release assets to GitHub https://github.com/nvaccess/nvda/actions/runs/17196535198/job/48780625010 Description of development approach: Get the name of the file before trying to upload it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #18556
Summary of the issue:
Beta/RC tags do not upload the exe to the release assets, unlike stable releases.
Additionally, to make it easier to discuss issues with betas, creating a beta discussion is useful.
It also allows us to easily share each new release in slack and other places via Discussions RSS feed. The releases RSS feed includes tags, which duplicates posts to slack.
If a build fails due to system tests, you cannot rebuild it as the cache gets deleted.
Description of user facing changes:
None
Description of developer facing changes:
GitHub discussions are created for betas and RCs.
All releases are auto-posted to slack.
The installer artifact is uploaded to the release assets.
Description of development approach:
fix up action
only delete cache on successful build
Testing strategy:
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary