Fix auto milestone action#18731
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the auto milestone action that was broken by previous changes. The action was failing due to insufficient permissions when attempting to automatically assign milestones to merged pull requests.
- Added
issues: writepermission to the GitHub workflow - Maintains existing
pull-requests: writepermission for milestone assignment
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
approved these changes
Aug 18, 2025
OzancanKaratas
pushed a commit
to OzancanKaratas/nvda
that referenced
this pull request
Aug 18, 2025
Summary of the issue: The auto milestone action has been broken since nvaccess#18396. Description of user facing changes: None Description of developer facing changes: Pull requests should have a milestone automatically applied on merge. Description of development approach: Gave the action write permission for issues. This is needed because PRs are considered to be a type of issue by GitHub. The action still needs write permission for pull requests as only users with merge permissions can add a milestone to pull requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
The auto milestone action has been broken since #18396.
Description of user facing changes:
None
Description of developer facing changes:
Pull requests should have a milestone automatically applied on merge.
Description of development approach:
Gave the action write permission for issues.
This is needed because PRs are considered to be a type of issue by GitHub. The action still needs write permission for pull requests as only users with merge permissions can add a milestone to pull requests.
Testing strategy:
Ran the action on a fork of NVDA.
issues: write: https://github.com/SaschaCowley/nvda/actions/runs/17027879005issuesandpull-requests: write: https://github.com/SaschaCowley/nvda/actions/runs/17027997599Known issues with pull request:
Still doesn't address the fact that PRs merged to beta/rc will get the wrong milestone, and PRs not merged to master/beta/rc shouldn't be milestoned at all.
Code Review Checklist:
@coderabbitai summary