Link to issue number:

Fixes #18003.

Summary of the issue:

The default threshold values for signed integer types are incorrect, becoming twice as large, causing more parts to be trimmed than expected.

Description of user facing changes:

The excessive trimming will be fixed.

Description of developer facing changes:

None.

Description of development approach:

WaveFormat::defaultThreshold should use 1 / 2^10 or 0.0009765625 as the threshold value for all types.

The current implementation handles floating points and unsigned integers correctly, but fails to differentiate the signedness, so signed integer types will have a threshold value that's twice as large.

The solution is to replace the case-by-case implementation to a more general and correct max() / (1 << 10).

Testing strategy:

I wrote a C++ program to run the silence detection algorithm on the user-provided wave data. Now the algorithm detects a consistent duration of silence for 16-bit, 24-bit, and 32-bit float formats.

Known issues with pull request:

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary