Skip to content

Add script to send ctrl+alt+del#18629

Merged
SaschaCowley merged 3 commits intomasterfrom
sendSASScript
Aug 12, 2025
Merged

Add script to send ctrl+alt+del#18629
SaschaCowley merged 3 commits intomasterfrom
sendSASScript

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley commented Aug 6, 2025

Link to issue number:

Closes #18105

Summary of the issue:

There's currently no script to send control+alt+delete to the controlled end of a Remote Access connection, which means the only way to do so if from the Remote Access menu..

Description of user facing changes:

Added an unassigned command to send control+alt+delete.

Description of developer facing changes:

None

Description of development approach:

Added a new script_sendSAS method to globalCommands.GlobalCommands.
Registered this script as a local script on the _remoteClient singleton so that it can be executed when sending keys.

Testing strategy:

Ran from source. Bound the script to a gesture (NVDA+alt+delete). Connected as leader and connected another computer as follower. Used the gesture when controlling the local computer and the remote computer.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Aug 12, 2025
@SaschaCowley SaschaCowley marked this pull request as ready for review August 12, 2025 02:45
Copilot AI review requested due to automatic review settings August 12, 2025 02:45
@SaschaCowley SaschaCowley requested a review from a team as a code owner August 12, 2025 02:45
@SaschaCowley SaschaCowley requested a review from seanbudd August 12, 2025 02:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for sending ctrl+alt+delete to a remote computer in NVDA's Remote Access feature. The functionality was missing, requiring users to navigate through the Remote Access menu to trigger this key combination when controlling a remote machine.

  • Adds a new unassigned command to send ctrl+alt+delete to the remote computer
  • Implements script registration with the remote client to enable the feature
  • Updates documentation to reflect the new functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
user_docs/en/changes.md Documents the new unassigned command in the changelog
source/globalCommands.py Implements the script_sendSAS method to send ctrl+alt+delete
source/_remoteClient/init.py Registers the new script as a local script in the remote client

@SaschaCowley SaschaCowley merged commit 8dffe62 into master Aug 12, 2025
55 of 57 checks passed
@SaschaCowley SaschaCowley deleted the sendSASScript branch August 12, 2025 05:14
seanbudd pushed a commit that referenced this pull request Aug 14, 2025
Follow-up to #18629
Summary of the issue:

#18629 added an (unassigned) script to send alt+ctrl+del via Remote Access, but this wasn't included in the list of Remote Access keyboard shortcuts.
Description of user facing changes:

This command is now listed in the list of Remote Access commands.
Description of developer facing changes:

None
@SaschaCowley SaschaCowley added this to the 2025.3 milestone Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked/needs-testing conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unassigned input gesture to send control alt delete in Remote Access

3 participants