Parallelize GitHub actions builds for 32/64 bit#18596
Merged
seanbudd merged 8 commits intowip-buildX64from Aug 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR parallelizes GitHub Actions builds to support both 32-bit (x86) and 64-bit (x64) architectures simultaneously. This change enables developing and testing both architectures in parallel, particularly useful for transitioning to 64-bit NVDA while maintaining 32-bit compatibility.
Key changes:
- Added matrix strategy to core build jobs (buildNVDA, createLauncher, unitTests, systemTests, createSymbols) to run for both x86 and x64 architectures
- Updated cache keys and artifact names to include architecture and Python version specifics
- Modified job outputs to handle matrix-based builds while preserving default architecture outputs for downstream jobs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/testAndPublish.yml | Added matrix strategy for dual architecture builds across all major CI jobs |
| .python-versions | Added 32-bit Python version specification for uv compatibility |
| miscDeps | Updated submodule commit to support dual architecture builds |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
seanbudd
added a commit
that referenced
this pull request
Aug 6, 2025
Taken from #18611 #18596 and #18207 Summary of the issue: We want to build 64bit and 32builds of NVDA in parallel for the 64bit migration and python migrations. As such, we should prepare our build system to take a matrix of python versions and architecture Description of user facing changes: None Description of developer facing changes: None Description of development approach: Refer to #18611 #18596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #18207
Summary of the issue:
While developing 64bit, we want to be able to build 32 and 64 bit versions of NVDA simultaneously, until a stable version is ready.
Similarly, it would be helpful to do the same for python upgrades.
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
Create dual builds for the following jobs:
Testing strategy:
This PR
Known issues with pull request:
System tests are still failing, as the installer is not fully working for both environments yet
Code Review Checklist:
@coderabbitai summary