Conversation
This was referenced Jul 25, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request removes branches from the AppVeyor CI configuration to transition from AppVeyor to GitHub Actions for building NVDA. The change restricts AppVeyor to only build tagged releases while PR builds, try builds, and snapshots will be handled by GitHub Actions.
- Removes
master,beta,rc, andtry-*branches from AppVeyor's build trigger list - Retains only
release-*branches for AppVeyor builds
Member
Author
|
testing has been performed, this is ready to merge tomorrow with server changes |
seanbudd
added a commit
that referenced
this pull request
Aug 6, 2025
Takes #18555 to beta to prevent beta/rc PRs and snapshots from building on appveyor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #17878
Summary of the issue:
As we transition from AppVeyor to GitHub Actions, we are nearly ready to deploy snapshots and releases via GHA.
For safety, we will perform tagged releases in the 2025.2 release cycle with AppVeyor still.
Description of user facing changes:
none
Description of developer facing changes:
AppVeyor will only build tagged releases.
PR builds, try builds and snapshots will now be built by GitHub actions.
Description of development approach:
removed lines from appveyor.yml. Appveyor uses master's copy of this file for all releases, unlike GitHub actions where it depends on the branches involved.
Testing strategy:
Not needed
Known issues with pull request:
blocked currently
Code Review Checklist:
@coderabbitai summary