UIA notification event handler: NotificationKind -> notificationKind, NotificationProcessing -> notificationProcessing (argument name consistency)#18319
Merged
seanbudd merged 3 commits intoJun 25, 2025
Conversation
…nProcessing -> notificationProcessing (argumetn name/resolving TypeError)
…ficationKind, NotificationProcessing -> notificationProcessing (argument name consistency with UIA object version)
Contributor
Author
|
NOte: this PR replaces #18317. |
5 tasks
seanbudd
approved these changes
Jun 24, 2025
Member
|
pre-commit.ci run |
Member
|
@josephsl - please fix up pre-commit failures |
… with correctly spelled argument names (cauht with Ruff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #18229:
Link to issue number:
None
Summary of the issue:
UIA notification argument names are inconsistent across UIA handler, app modules, and UIA NVDA objects.
Description of user facing changes:
None
Description of developer facing changes:
None, as the app module API was just merged.
Description of development approach:
Change the follwoing argument names in app module version of shouldProcessUIANotificationEvent:
Testing strategy:
Manual: make sure UIA notifications such as volume changes and window style changes are announced.
Known issues with pull request:
We may need to revisit UIA handler notification event handler argument names in 2026.1 dev cycle - this PR attempts to correct part of the inconsistency issue, with the event handler change proposed for 2026.1.
Code Review Checklist:
@coderabbitai summary