Skip to content

File Explorer app module: correct notification event argument names#18317

Closed
josephsl wants to merge 1 commit into
nvaccess:masterfrom
josephsl:i18220followupExplorerNotificationEventArgumentNames
Closed

File Explorer app module: correct notification event argument names#18317
josephsl wants to merge 1 commit into
nvaccess:masterfrom
josephsl:i18220followupExplorerNotificationEventArgumentNames

Conversation

@josephsl

Copy link
Copy Markdown
Contributor

Quick follow-up:

Link to issue number:

None

Summary of the issue:

File Explorer app module uses title case for notification event handler argument names.

Description of user facing changes:

None

Description of developer facing changes:

File Explorer's notification event argument names are corrected.

Description of development approach:

Argument name corrections:

  • NotificationKind -> notificationKind
  • NotificationProcessing -> notificationProcessing

Testing strategy:

Manual: make sure UIA notification events are raised without TypeError tracebacks.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

…nProcessing -> notificationProcessing (argumetn name/resolving TypeError)
@josephsl

Copy link
Copy Markdown
Contributor Author

Superseded by #18319, closing.

@josephsl josephsl closed this Jun 24, 2025
@josephsl josephsl deleted the i18220followupExplorerNotificationEventArgumentNames branch June 25, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant