Skip to content

Revert #17573 and #16248#18318

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
cary-rowen:revertFixVSC
Jun 25, 2025
Merged

Revert #17573 and #16248#18318
seanbudd merged 1 commit into
nvaccess:masterfrom
cary-rowen:revertFixVSC

Conversation

@cary-rowen

Copy link
Copy Markdown
Contributor

Reverts PR

Reverts #17573, #16248

Issues fixed

n/a

Issues reopened

n/a

Reason for revert

#18271 is a more general implementation, fixed from the root #16246.

Can this PR be reimplemented? If so, what is required for the next attempt

n/a

@cary-rowen cary-rowen requested a review from a team as a code owner June 24, 2025 14:18
@cary-rowen cary-rowen requested a review from seanbudd June 24, 2025 14:18
@LeonarddeR

Copy link
Copy Markdown
Collaborator

Please provide more details in your initial description.

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jun 24, 2025
@SaschaCowley SaschaCowley added this to the 2025.2 milestone Jun 24, 2025
Comment thread user_docs/en/changes.md
* When pasting into the Windows 10/11 Calculator, NVDA now correctly reports the full number pasted. (#16573, @TristanBurchett)
* Speech is no longer silent after disconnecting from and reconnecting to a Remote Desktop session. (#16722, @jcsteh)
* Support added for text review commands for an object's name in Visual Studio Code. (#16248, @Cary-Rowen)
* Playing NVDA sounds no longer fails on a mono audio device. (#16770, @jcsteh)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo modifications to the changelog of already finalised releases

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 1e66296b0e

@seanbudd seanbudd merged commit abef7b5 into nvaccess:master Jun 25, 2025
16 of 17 checks passed
jcsteh added a commit to jcsteh/nvda that referenced this pull request Jul 21, 2025
jcsteh added a commit to jcsteh/nvda that referenced this pull request Jul 21, 2025
SaschaCowley pushed a commit that referenced this pull request Jul 21, 2025
Reverts PR
Reverts #18271 and #18318.

Issues fixed
Fixes #18498.

Issues reopened
Reopens #15159. Reopens #11285.

Reason for revert
Causes regression #18498.

Can this PR be reimplemented? If so, what is required for the next attempt
Unknown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants