Merged
Conversation
SaschaCowley
approved these changes
Apr 7, 2025
nvdaes
pushed a commit
to nvdaes/nvda
that referenced
this pull request
Apr 10, 2025
Fixup to nvaccess#17728 Due to nvaccess#17878 Summary of the issue: GitHub actions is now building NVDA, however we are not ready to release and deploy a signed copy of NVDA yet (see nvaccess#17878). As such, we shouldn't build tagged releases with GitHub actions Description of user facing changes None Description of development approach Disable tagged releases from GitHub actions until nvaccess#17878 is closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup to #17728
Due to #17878
Summary of the issue:
GitHub actions is now building NVDA, however we are not ready to release and deploy a signed copy of NVDA yet (see #17878).
As such, we shouldn't build tagged releases with GitHub actions
Description of user facing changes
None
Description of development approach
Disable tagged releases from GitHub actions until #17878 is closed