Word collapse/expand headings: add gestures with numlock on#17901
Merged
Conversation
5 tasks
Contributor
Author
seanbudd
approved these changes
Apr 6, 2025
seanbudd
added a commit
that referenced
this pull request
Apr 7, 2025
Fixes #10827 Blocking #17901 Summary of the issue: In NVDA's code, when numpadPlus, numpadMinus, numpadMultiply and numpadDivide is pressed, we make a difference if numlock is enabled or disabled, by artificially making numlock a modifier. Though, when numlock modifier is used in a gesture's key name and gesture.send is used, numlock key event is really sent to the system, causing numlock deactivation. Description of user facing changes None Description of development approach In KeyboardInputGesture.send method, filter numlock as a modifier so that it is never sent to the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up of #17545
Blocked by #17900
Summary of the issue:
#17545 has implemented the announcement resulting of the action to collapse or expand headings in Word with
shift+alt+plus/-when using plus/minus on the main keyboard and on the numpad. Thought, using the numpad plus/minus key on the numpad does not report anything if numlock is enabled.Description of user facing changes
alt+shift+numpadPlus/Minuswill now report headings expanding / collapsing, no matter if numlock is on or off.Description of development approach
Added the two gestures with numlock on in the gestures list of the script.
Testing strategy:
In a branch integrating #17900, tested the script on Word with numlock on and off.
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary