Fix-up of the toggle apps volume control command#17885
Closed
CyrilleB79 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@mltony, @LeonarddeR, @ABuffEr, @codeofdusk: Since you were interested or impacted by this feature in some way, could you please perform additional user tests, in case I have forgotten one case to test. |
Member
|
Closing - we are reverting apps volume command due to #17654 |
SaschaCowley
pushed a commit
that referenced
this pull request
Apr 4, 2025
### Reverts PR Reverts #17271 Reverts #16591 Reverts #17634 ### Issues fixed Fixes #17654 Fixes #17882 Fixes #17124 Fixes #17656 ### Issues reopened Reopens #16052 ### Reason for revert - #17654: The applications volume adjust feature is affecting Windows sound output even if the feature is disabled. - #17882: bug: NVDA does not announce when application volume control feature is toggled using assigned gesture - #17124: unclear UX in regards to if the settings should be profile independent - #17656: NVDA doesn't control the volume of applications which use non-default windows output ### Can this PR be reimplemented? If so, what is required for the next attempt - Refer to debug suggestions in #17654 (comment) - Ensure #17124 is considered in the next attempt - See #17885 for fix for #17882 - #17656 should at least be documented, if not resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17882
Summary of the issue:
The toggle command for apps volume control does not report its state after having performed the switch.
Also, while fixing this, I have realized that some state comparison were not performed as expected: confusion between volume control state (enabled/disabled) vs config state (enabled/disabled/default)
Description of user facing changes
The command now works as expected.
Description of development approach
Testing strategy:
Manual tests:
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary