Fix installing a downloaded update#17812
Merged
Merged
Conversation
Collaborator
|
Can we have this merged ASAP? It is a bit painful to download every update manually. |
michaelDCurran
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17811
Follow-up to #17310
Summary of the issue:
Attempting to install a just-downloaded update fails on latest alphas.
Description of user facing changes
Update installation should work again
Description of development approach
Fixed several instances of property access on the
UpdateInfoobject using snake_case instead of camelCase.Testing strategy:
Created a portable from source, spoofing the version and update version type:
Ran the following tests:
Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary