Skip to content

Fix installing a downloaded update#17812

Merged
SaschaCowley merged 1 commit into
masterfrom
fixUpdateInstaller
Mar 20, 2025
Merged

Fix installing a downloaded update#17812
SaschaCowley merged 1 commit into
masterfrom
fixUpdateInstaller

Conversation

@SaschaCowley

@SaschaCowley SaschaCowley commented Mar 11, 2025

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #17811
Follow-up to #17310

Summary of the issue:

Attempting to install a just-downloaded update fails on latest alphas.

Description of user facing changes

Update installation should work again

Description of development approach

Fixed several instances of property access on the UpdateInfo object using snake_case instead of camelCase.

Testing strategy:

Created a portable from source, spoofing the version and update version type:

./scons source version=2024.1 updateVersionType=stable

Ran the following tests:

  1. Update and install immediately
    1. Launch the portable
    2. Check for updates, and download the update
    3. When prompted, choose to install the update
    4. Wait for the launcher to run, then cancel by answering No when asked whether to update the portable
  2. Update and install later manually
    1. Launch the portable
    2. Check for updates, and download the update
    3. When prompted, choose to postpone the update
    4. Exit NVDA via the exit dialog, and choose to install the pending update
    5. Wait for the launcher to run, then cancel by answering No when asked whether to update the portable
  3. Update and install later when prompted
    1. Launch the portable
    2. Check for updates, and download the update
    3. When prompted, choose to postpone the update
    4. Restart the portable
    5. When prompted, choose to install the pending update
    6. Wait for the launcher to run, then cancel by answering No when asked whether to update the portable

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review March 11, 2025 08:24
@SaschaCowley SaschaCowley requested a review from a team as a code owner March 11, 2025 08:24
@LeonarddeR

Copy link
Copy Markdown
Collaborator

Can we have this merged ASAP? It is a bit painful to download every update manually.

@SaschaCowley SaschaCowley merged commit 17d5fcc into master Mar 20, 2025
@SaschaCowley SaschaCowley deleted the fixUpdateInstaller branch March 20, 2025 22:53
@github-actions github-actions Bot added this to the 2025.1 milestone Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue updating NVDA to the latest Alpha Release.

3 participants