Allow update all add-ons button to be pressed only once#17713
Merged
Conversation
SaschaCowley
approved these changes
Feb 21, 2025
gexgd0419
pushed a commit
to gexgd0419/nvda
that referenced
this pull request
Feb 22, 2025
Fixes nvaccess#17110 Summary of the issue: Ever since nvaccess#16636, users have been able to press the "update all" button to execute downloading and installing all the add-ons multiple times. This is because the update all button is disabled after the add-ons have finished downloading, not immediately after it is clicked, preventing subsequent activations. Description of user facing changes Users are unable to press update all button multiple times until add-ons finish downloading. Description of development approach Disable update all button immediately after first activation. Testing strategy: Manual testing by simulating slow internet updating multiple add-ons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #17110
Summary of the issue:
Ever since #16636, users have been able to press the "update all" button to execute downloading and installing all the add-ons multiple times.
This is because the update all button is disabled after the add-ons have finished downloading, not immediately after it is clicked, preventing subsequent activations.
Description of user facing changes
Users are unable to press update all button multiple times until add-ons finish downloading.
Description of development approach
Disable update all button immediately after first activation.
Testing strategy:
Manual testing by simulating slow internet updating multiple add-ons
Known issues with pull request:
Code Review Checklist:
@coderabbitai summary