Split Java Access Bridge calls to fix NVDA crashes when selecting whole text in specific source files in Android studio#17604
Merged
SaschaCowley merged 7 commits intoJan 20, 2025
Conversation
See test results for failed build of commit c545bb5896 |
Summary of the issue: Nvda crashes when selecting whole text in specific source files in Android Studio and IntelliJ Idea Description of user facing changes NVDA should no longer crash. Description of development approach Java Access Bridge has a buffer limit of 10240 characters for the text. If the text is too large to fit on this buffer size, NVDA will split the calls to take the buffer size in account.
5341d7e to
6973d4d
Compare
SaschaCowley
requested changes
Jan 13, 2025
SaschaCowley
left a comment
Member
There was a problem hiding this comment.
Just a couple of small requests and questions
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
SaschaCowley
requested changes
Jan 15, 2025
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
Co-authored-by: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com>
SaschaCowley
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #17418
Summary of the issue:
Nvda crashes when selecting whole text in specific source files in Android Studio and IntelliJ Idea
Description of user facing changes
NVDA should no longer crash.
Description of development approach
Java Access Bridge has a buffer limit of 10240 characters for the text. If the text is too large to fit on this buffer size, NVDA will split the calls to take the buffer size in account.
Testing strategy:
Tested with IntelliJ idea and the file provided on the issue.
Known issues with pull request:
No known issues were identified.
Code Review Checklist:
@coderabbitai summary