Merge 5341d7e into e06f2b8

thgcode · web-flow · commit c545bb589646 · 2025-01-09T21:11:35.000-03:00
diff --git a/source/JABHandler.py b/source/JABHandler.py
@@ -647,7 +647,7 @@ def getAccessibleTextSelectionInfo(self):
 		bridgeDll.getAccessibleTextSelectionInfo(self.vmID, self.accContext, byref(textSelectionInfo))
 		return textSelectionInfo
 
-	def getAccessibleTextRange(self, start, end):
+	def _javaGetAccessibleTextRange(self, start, end):
 		length = (end + 1) - start
 		if length <= 0:
 			return ""
@@ -656,6 +656,24 @@ def getAccessibleTextRange(self, start, end):
 		bridgeDll.getAccessibleTextRange(self.vmID, self.accContext, start, end, buf, length)
 		return textUtils.getTextFromRawBytes(buf.raw, numChars=length, encoding=textUtils.WCHAR_ENCODING)
 
+	# Constant gotten from AccessBridgePackages.h,
+	# minus one to accommodate the null character
+	MAX_BUFFER_SIZE = 10239
+
+	def getAccessibleTextRange(self, start, end):
+		length = (end + 1) - start
+		if length <= 0:
+			return ""
+
+		text = []
+		while start <= end:
+			bufferSize = min(self.MAX_BUFFER_SIZE, length)
+			text.append(self._javaGetAccessibleTextRange(start, start + bufferSize - 1))
+			start += bufferSize
+			length = (end + 1) - start
+
+		return "".join(text)
+
 	def getAccessibleTextLineBounds(self, index):
 		index = max(index, 0)
 		log.debug("lineBounds: index %s" % index)
diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md
@@ -53,6 +53,7 @@ Prefix matching on command line flags, e.g. using `--di` for `--disable-addons`
 
 ### Bug Fixes
 
+* NVDA will no longer crash when selecting whole text in specific source files in Android Studio or IntelliJ Idea. (#17418, @thgcode)
 * Math reading has been fixed for some web elements.
 Specifically, MathML inside of span and other elements that have the attribute `role="math"`. (#15058)
 * Native support for the Dot Pad tactile graphics device from Dot Inc as a multiline braille display. (#17007)
