Skip to content

No more focus event issue after reloading appModules#17322

Merged
SaschaCowley merged 4 commits into
nvaccess:masterfrom
CyrilleB79:reloadAppModules
Nov 6, 2024
Merged

No more focus event issue after reloading appModules#17322
SaschaCowley merged 4 commits into
nvaccess:masterfrom
CyrilleB79:reloadAppModules

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Fixes #17323

Summary of the issue:

After a reload of plugins (NVDA+control+f3), focus events do not report the new focus as expected.

During focus event, NVDA tests which tree interceptors are alive or not to clean up those which are dead. In this test, for MSHTML, NVDA looks at root.appModule.appName, root being the root object associated to the virtual MSHTML buffer.

However, root.appModule may be None after plugins are reloaded.

Description of user facing changes

After plugins are reloaded while a browseable message is opened, the focus will no longer fail to be reported.

Description of development approach

Fixed the logic for MSHTML

Testing strategy:

Tested STR in #17323.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@CyrilleB79 CyrilleB79 marked this pull request as ready for review October 24, 2024 15:32
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner October 24, 2024 15:32
@CyrilleB79 CyrilleB79 requested a review from seanbudd October 24, 2024 15:32
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Oct 28, 2024
@seanbudd

seanbudd commented Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I merged #17334 from @LeonarddeR. can you resolve conflicts?

@CyrilleB79

CyrilleB79 commented Nov 4, 2024

Copy link
Copy Markdown
Contributor Author

@seanbudd, I have upmerged from latest master.

The changes that I had made in source/keyboardHandler.py have been taken by @LeonarddeR in #17334 so this file is not part of this PR anymore.

@CyrilleB79

CyrilleB79 commented Nov 4, 2024

Copy link
Copy Markdown
Contributor Author

Also updated the initial description consequently.

seanbudd
seanbudd approved these changes Nov 4, 2024
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@SaschaCowley SaschaCowley merged commit c729a71 into nvaccess:master Nov 6, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Nov 6, 2024
@CyrilleB79 CyrilleB79 deleted the reloadAppModules branch November 6, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2025.1

Development

Successfully merging this pull request may close these issues.

Focused objects not reported after a plugins reload

3 participants

@CyrilleB79 @seanbudd @SaschaCowley