Slightly rework shouldUseToUnicodeEx to avoid errors#17334
Merged
Conversation
38c2b78 to
3ef8a8f
Compare
seanbudd
approved these changes
Nov 4, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
shouldUseToUnicodeExcan sometimes result in none object has no property helperLocalBindingHandle error. This is hard to reproduce but I've seen it often in WhatsApp UWP.Description of user facing changes
None known.
Description of development approach
helperLocalBindingHandle, ensure thatappModulehas a value.Testing strategy:
Should be tested during daily use as it is hard to reproduce the underlying issue.
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary