Skip to content

Slightly rework shouldUseToUnicodeEx to avoid errors#17334

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:noneAppModule
Nov 4, 2024
Merged

Slightly rework shouldUseToUnicodeEx to avoid errors#17334
seanbudd merged 1 commit into
nvaccess:masterfrom
LeonarddeR:noneAppModule

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

shouldUseToUnicodeEx can sometimes result in none object has no property helperLocalBindingHandle error. This is hard to reproduce but I've seen it often in WhatsApp UWP.

Description of user facing changes

None known.

Description of development approach

  1. When checking for helperLocalBindingHandle, ensure that appModule has a value.
  2. While at it, reorder the checks, since in current era, UWP applications are much more common than during the initial implementation of this approach.

Testing strategy:

Should be tested during daily use as it is hard to reproduce the underlying issue.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner October 28, 2024 09:20
@LeonarddeR LeonarddeR requested a review from seanbudd October 28, 2024 09:20
@seanbudd seanbudd added conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. merge-early Merge Early in a developer cycle labels Oct 28, 2024
@seanbudd seanbudd merged commit 7cb5139 into nvaccess:master Nov 4, 2024
@github-actions github-actions Bot added this to the 2025.1 milestone Nov 4, 2024
@LeonarddeR LeonarddeR deleted the noneAppModule branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. merge-early Merge Early in a developer cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants