Speech feedback on more Word formatting shortcuts#17197
Merged
seanbudd merged 13 commits intoSep 26, 2024
Conversation
Contributor
Author
|
For the much more common underline shortcut |
caa7e90 to
48c7e8c
Compare
Member
|
@CyrilleB79 - I think to be consistent we need to solve 2 problems:
My preference would be:
But I would accept the current alternative of:
|
…el is not stable.
This reverts commit ba1396f.
Contributor
Author
|
@seanbudd, I have done the following change and updated the initial description:
I'll pass this PR to ready state as soon as the build and tests are successful. |
seanbudd
reviewed
Sep 25, 2024
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
Contributor
Author
|
@seanbudd thanks for your review. The changes have been applied. |
seanbudd
approved these changes
Sep 25, 2024
This was referenced Nov 22, 2024
seanbudd
pushed a commit
that referenced
this pull request
Nov 26, 2024
Fixes #10271 (last part) Also could be considered a partial fix of #3293. Summary of the issue: In Word / Outlook, nothing is reported when using the switch case command (shift+f3 in both, control+shift+a in Outlook only). Since it is a toggle/cycle command, the user needs to have the result to be reported. Description of user facing changes Using the switch case formatting command in Word or Outlook now reports its result, i.e. the type of case in which the selection has been formatted. When possible, the message being reported illustrates its own casing, as in Word menus, e.g. "lower case", "UPPERCASE", "Each Word Capitalized"; this may be useful in braille. Exception, for "Mixed case", I have not done something such as "mIxEd cAsE" because it is not correctly understandable through speech. Description of development approach Used Word object model as for other Word formatting scripts. Introduced a delay (set empirically), since the property retrieved from the object model transitions through other values (no case or lower case) before reaching its definitive value. Bind gestures according to the ones existing in Word and Outlook. Note: shift+f3 performs case switch both in Word and Outlook, whereas control+shift+A does it only in Outlook. See "Notes about various capitalization shortcuts" in #17197 for more details.
CyrilleB79
pushed a commit
to CyrilleB79/nvda
that referenced
this pull request
Mar 17, 2025
Word/Outlook: Underline double (nvaccess#17197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes (at least partially) #10271
Supersedes #10283.
Summary of the issue:
User wants to have font formatting state announced when native font formatting shortcut are executed under Word and Outlook.
Description of user facing changes
The results of the following MS Word shortcuts are now reported:
control+shift+D: Underline doublecontrol+shift+W: Underline words onlycontrol+shift+A: All capsctrl+Shift+K: Small capsctrl+shift+i,ctrl+shift+bandctrl+shift+u: alternative gestures for toggle italic, bold and underline.When relevant, these shortcuts are also reported in Outlook.
Notes about various capitalization shortcuts
In Word, the Shift+F3 and Ctrl+Shift+A shortcuts are slightly different:
Outlook's Ctrl+Shift+A shortcut is equivalent to Word's Shift+F3, whereas Word's Ctrl+Shift+A has no equivalent under Outlook as far as I know.
Messages
Word's shortcuts Ctrl+Shift+A, Ctrl+Shift+K and Shift+F3 modify all the selection's (or current word's) capitalization. However, Ctrl+Shift+A and Ctrl+Shift+K also impact the next characters that will be typed. Thus for this shortcut "on" and "off" have been used in their announced message in order to denote a state change. On the contrary Shift+F3 announces only the result of a modification of current selection (or word); thus "on" and "off" have not been used in its message.
Description of development approach
Use object model and polling to check state change, as done for other formatting scripts.
Testing strategy:
Tested all combinations:
Known issues with pull request:
shift+f3(in both Word and Outlook) andcontrol+shift+Ain Outlook only. However, the object model property looked at for this sometimes transition through an intermediate state. Thus, this command is finally not supported by this PR, i.e. nothing is reported, rather than taking the risk to report something erroneous from time to time.gestures.inifiles in SRT repo (or elsewhere if the process changes) according to native Word or Outlook shortcuts in their language if these differ from English. I plan to inform them in detail when the beta translation freeze occurs. Or to open a separate dedicated PR if it is the new process.Code Review Checklist:
@coderabbitai summary