Skip to content

Revert "Use moveToCodepointOffset for cursor routing"#16539

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:revert-16497-fixupRouting
May 14, 2024
Merged

Revert "Use moveToCodepointOffset for cursor routing"#16539
seanbudd merged 4 commits into
nvaccess:masterfrom
LeonarddeR:revert-16497-fixupRouting

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Reverts PR

Reverts #16477 , #16497

Issues fixed

None

Issues reopened

Reopens #10960

Reason for revert

Feature turns out to be unstable.

Can this PR be reimplemented? If so, what is required for the next attempt

  1. Use a feature flag
  2. Ensure issues reported in Fix routing to account for rawToContentPos #16497 (comment) and Fix routing to account for rawToContentPos #16497 (comment) are covered by the fix

@LeonarddeR LeonarddeR requested a review from a team as a code owner May 13, 2024 09:28
@LeonarddeR LeonarddeR requested a review from seanbudd May 13, 2024 09:28
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 14, 2024
@seanbudd seanbudd merged commit fd98f5a into nvaccess:master May 14, 2024
LeonarddeR added a commit to LeonarddeR/nvda that referenced this pull request May 14, 2024
@LeonarddeR LeonarddeR deleted the revert-16497-fixupRouting branch August 23, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants